r34918 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:r34917 | r34918 (on ViewVC) | r34919 >
Date:12:38, 16 May 2008
Author:ashley
Status:ok
Tags:
Comment:MultiUpload:
*apply ADi's patch from http://www.mediawiki.org/wiki/Extension_talk:MultiUpload#possible_bugs_-_29805
*add version number to wgExtensionCredits
Modified paths:

Diff [purge]

Index: trunk/extensions/MultiUpload/SpecialMultipleUpload.php
===================================================================
--- trunk/extensions/MultiUpload/SpecialMultipleUpload.php	(revision 34917)
+++ trunk/extensions/MultiUpload/SpecialMultipleUpload.php	(revision 34918)
@@ -3,13 +3,12 @@
     die();
 
 /**#@+
- * An extension that allows users to upload multiple photos at once.
+ * An extension that allows users to upload multiple files at once.
  *
  * @addtogroup Extensions
  *
  * @link http://www.mediawiki.org/wiki/Extension:MultiUpload
  *
- *
  * @author Travis Derouin <travis@wikihow.com>
  * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
  */
@@ -22,6 +21,7 @@
 $wgExtensionCredits['specialpage'][] = array(
 	'name'           => 'MultipleUpload',
 	'author'         => 'Travis Derouin',
+	'version'        => '1.0',
 	'description'    => 'Allows users to upload several files at once.',
 	'descriptionmsg' => 'multipleupload-desc',
 	'url'            => 'http://www.mediawiki.org/wiki/Extension:MultiUpload',
@@ -141,8 +141,8 @@
             $this->mIgnoreWarning = true;
 
 			$this->mUploadError = $this->mUploadErrorArray [$x];
-			$this->mDestFile = $this->mDestFileArray [$x];
-			$this->mUploadDescription = $this->mUploadDescriptionArray [$x];
+			$this->mDesiredDestName = $this->mDestFileArray [$x];
+			$this->mComment = $this->mUploadDescriptionArray [$x];
 			$wgOut->addHTML("<tr><td>");
 			parent::processUpload();
 			$wgOut->addHTML("</td></tr>");
@@ -242,8 +242,7 @@
 		$reupload = wfMsgHtml( 'reupload' );
 		$iw = wfMsgWikiHtml( 'multipleupload-ignoreallwarnings' );
 		$reup = wfMsgWikiHtml( 'reuploaddesc' );
-		if ( $wgUseCopyrightUpload )
-		{
+		if ( $wgUseCopyrightUpload ) {
 			$copyright =  "
 	<input type='hidden' name='wpUploadCopyStatus' value=\"" . htmlspecialchars( $this->mUploadCopyStatus ) . "\" />
 	<input type='hidden' name='wpUploadSource' value=\"" . htmlspecialchars( $this->mUploadSource ) . "\" />
@@ -410,7 +409,7 @@
 		");
 		}
 
-		$wgOut->addHtml( "
+		$wgOut->addHTML( "
 		<td>
  			<input tabindex='7' type='checkbox' name='wpWatchthis' id='wpWatchthis' $watchChecked value='true' />
 			<label for='wpWatchthis'>" . wfMsgHtml( 'watchthis' ) . "</label>
@@ -477,4 +476,4 @@
         $wgOut->addHTML( $text );
     }
     return true;
-}
+}
\ No newline at end of file
Views
Toolbox