MediaWiki r34388 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r34387‎ | r34388 (on ViewVC)‎ | r34389 >
Date:18:57, 7 May 2008
Author:catrope
Status:old
Tags:
Comment:
Fixing regression from r34353: using Database::select() for a join messes up in certain cases (puts `s where they don't belong, breaking SQL), but not for all joins. Seems to be related to table aliases, not sure though.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -65,7 +65,7 @@
6666 if (!is_null($params['group'])) {
6767 // Filter only users that belong to a given group
6868 $tblName = $db->tableName('user_groups');
69 - $tables = "$tables INNER JOIN $tblName ug1 ON ug1.ug_user=user_id";
 69+ $tables = "$tables INNER JOIN $tblName ug1 ON `ug1`.`ug_user`=`user_id`";
7070 $this->addWhereFld('ug1.ug_group', $params['group']);
7171 }
7272
@@ -76,7 +76,7 @@
7777 $sqlLimit = $limit+$groupCount+1;
7878
7979 $tblName = $db->tableName('user_groups');
80 - $tables = "$tables LEFT JOIN $tblName ug2 ON ug2.ug_user=user_id";
 80+ $tables = "$tables LEFT JOIN $tblName ug2 ON `ug2`.`ug_user`=`user_id`";
8181 $this->addFields('ug2.ug_group ug_group2');
8282 } else {
8383 $sqlLimit = $limit+1;
Index: trunk/phase3/includes/api/ApiQueryUsers.php
@@ -80,13 +80,13 @@
8181
8282 if(isset($this->prop['groups'])) {
8383 $ug = $db->tableName('user_groups');
84 - $tables = "$tables LEFT JOIN $ug ON ug_user=u1.user_id";
 84+ $tables = "$tables LEFT JOIN $ug ON `ug_user`=`u1`.`user_id`";
8585 $this->addFields('ug_group');
8686 }
8787 if(isset($this->prop['blockinfo'])) {
8888 $ipb = $db->tableName('ipblocks');
89 - $tables = "$tables LEFT JOIN $ipb ON ipb_user=u1.user_id";
90 - $tables = "$tables LEFT JOIN $userTable AS u2 ON ipb_by=u2.user_id";
 89+ $tables = "$tables LEFT JOIN $ipb ON `ipb_user`=`u1`.`user_id`";
 90+ $tables = "$tables LEFT JOIN $userTable AS u2 ON `ipb_by`=`u2`.`user_id`";
9191 $this->addFields(array('ipb_reason', 'u2.user_name AS blocker_name'));
9292 }
9393 $this->addTables($tables);

Follow-up revisions

Rev.Commit summaryAuthorDate
r34426Reverting r34388, DanTMan fixed Database::select() in r34442.catrope10:05, 8 May 2008

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r34353New config variables. $wgSharedPrefix and $wgSharedTables....dantman04:44, 7 May 2008

Status & tagging log

  • 15:26, 12 September 2011 Meno25 (talk | contribs) changed the status of r34388 [removed: ok added: old]