MediaWiki r33800 - Code Review

Index: trunk/phase3/includes/DefaultSettings.php
===================================================================
--- trunk/phase3/includes/DefaultSettings.php	(revision 33799)
+++ trunk/phase3/includes/DefaultSettings.php	(revision 33800)
@@ -1107,10 +1107,6 @@
 // Implicit group for accounts that pass $wgAutoConfirmAge
 $wgGroupPermissions['autoconfirmed']['autoconfirmed'] = true;
 
-// Implicit group for accounts with confirmed email addresses
-// This has little use when email address confirmation is off
-$wgGroupPermissions['emailconfirmed']['emailconfirmed'] = true;
-
 // Users with bot privilege can have their edits hidden
 // from various log pages by default
 $wgGroupPermissions['bot'  ]['bot']              = true;
@@ -1261,7 +1257,6 @@
 		array( APCOND_EDITCOUNT, &$wgAutoConfirmCount ),
 		array( APCOND_AGE, &$wgAutoConfirmAge ),
 	),
-	'emailconfirmed' => APCOND_EMAILCONFIRMED,
 );
 
 /**
@@ -3047,4 +3042,4 @@
  * maintenance/generateSitemap.php script is run, or false
  * if one is to be generated for all namespaces.
  */
-$wgSitemapNamespaces = false;
\ No newline at end of file
+$wgSitemapNamespaces = false;
Index: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	(revision 33799)
+++ trunk/phase3/RELEASE-NOTES	(revision 33800)
@@ -30,6 +30,9 @@
   $wgUserNotifiedOnAllChanges
 * (bug 12860) New option $wgSitemapNamespaces allows sitemaps to be generated
   for only some namespaces
+* Removed the emailconfirmed implicit group by default. To re-add it, use:
+    $wgAutopromote['emailconfirmed'] = APCOND_EMAILCONFIRMED;
+  in your LocalSettings.php.
 
 === New features in 1.13 ===