MediaWiki r33607 - Code Review

Repository:	MediaWiki
Revision:	< r33606‎ \| r33607 (on ViewVC)‎ \| r33608 >
Date:	16:46, 19 April 2008
Author:	vasilievvv
Status:	old
Tags:
Comment:	* (bug 13793) Special:Whatlinkshere filters wrong - after paginating instead of before
Modified paths:	/trunk/phase3/RELEASE-NOTES (modified) (history) (diff) /trunk/phase3/includes/SpecialWhatlinkshere.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/SpecialWhatlinkshere.php
—	—	@@ -99,6 +99,11 @@
100	100	'pl_namespace' => $target->getNamespace(),
101	101	'pl_title' => $target->getDBkey(),
102	102	);
	103	+ if( $this->hideredirs ) {
	104	+ $plConds['page_is_redirect'] = 0;
	105	+ } elseif( $this->hidelinks ) {
	106	+ $plConds['page_is_redirect'] = 1;
	107	+ }
103	108
104	109	$tlConds = array(
105	110	'page_id=tl_from',
—	—	@@ -220,11 +225,6 @@
221	226
222	227	$wgOut->addHTML( $this->listStart() );
223	228	foreach ( $rows as $row ) {
224		~~- if( $this->hideredirs && $row->page_is_redirect )~~
225		~~- continue;~~
226		~~- if( $this->hidelinks && ( !$row->page_is_redirect && !$row->is_template ) )~~
227		~~- continue;~~
228		-
229	229	$nt = Title::makeTitle( $row->page_namespace, $row->page_title );
230	230
231	231	$wgOut->addHTML( $this->listItem( $row, $nt ) );
Index: trunk/phase3/RELEASE-NOTES
—	—	@@ -206,8 +206,8 @@
207	207	* Do not display empty columns on Special:UserRights if all groups are
208	208	changeable or all unchangeable
209	209	* Fix fatal error on calling PAGESINCATEGORY with invalid category name
	210	+* (bug 13793) Special:Whatlinkshere filters wrong - after paginating instead of before
210	211
211		-
212	212	=== API changes in 1.13 ===
213	213
214	214	* Fixing main page display in meta=siteinfo

15:26, 12 September 2011 Meno25 (talk | contribs) changed the status of r33607 [removed: ok added: old]