MediaWiki r33387 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r33386‎ | r33387 (on ViewVC)‎ | r33388 >
Date:19:02, 15 April 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 13725) Upload form watch checkbox state set correctly with wpDestFile

r33330 just disabled the check for wpDestFile, so that the 'watch pages i create'
setting would watch *all* uploads. The system now checks the actual value, so
it sets the watch checkbox if the requested file doesn't exist locally and you
have it set for creations, or if you've already got the file watched.

There are still some minor issues:
* Since you have the chance to change the target filename on the form, the
initial checkbox state can get out of sync if you switch from an empty file
to an existing file or vice-versa.
* Unlike the edit form, the upload form doesn't _unwatch_ a previously-watched
page when the box is unchecked.
Modified paths:

Diff [purge]

Loading diff…

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r33330Revert strange dest check from r17248 (bug 13725)aaron06:23, 15 April 2008

Status & tagging log

  • 15:26, 12 September 2011 Meno25 (talk | contribs) changed the status of r33387 [removed: ok added: old]