MediaWiki r30736 - Code Review

Index: trunk/phase3/includes/DefaultSettings.php
===================================================================
--- trunk/phase3/includes/DefaultSettings.php	(revision 30735)
+++ trunk/phase3/includes/DefaultSettings.php	(revision 30736)
@@ -1013,6 +1013,11 @@
 $wgEnableSidebarCache = false;
 
 /**
+ * Expiry time for the sidebar cache, in seconds
+ */
+$wgSidebarCacheExpiry = 86400;
+
+/**
  * Under which condition should a page in the main namespace be counted
  * as a valid article? If $wgUseCommaCount is set to true, it will be
  * counted if it contains at least one comma. If it is set to false
Index: trunk/phase3/includes/Skin.php
===================================================================
--- trunk/phase3/includes/Skin.php	(revision 30735)
+++ trunk/phase3/includes/Skin.php	(revision 30736)
@@ -1602,7 +1602,7 @@
 	 * @private
 	 */
 	function buildSidebar() {
-		global $parserMemc, $wgEnableSidebarCache;
+		global $parserMemc, $wgEnableSidebarCache, $wgSidebarCacheExpiry;
 		global $wgLang, $wgContLang;
 
 		$fname = 'SkinTemplate::buildSidebar';
@@ -1663,7 +1663,7 @@
 			}
 		}
 		if ($cacheSidebar)
-			$parserMemc->set( $key, $bar, 86400 );
+			$parserMemc->set( $key, $bar, $wgSidebarCacheExpiry );
 		wfProfileOut( $fname );
 		return $bar;
 	}