MediaWiki r30736 - Code Review

Repository:	MediaWiki
Revision:	< r30735‎ \| r30736 (on ViewVC)‎ \| r30737 >
Date:	09:11, 9 February 2008
Author:	tstarling
Status:	old
Tags:
Comment:	Configurable expiry time for the sidebar cache
Modified paths:	/trunk/phase3/includes/DefaultSettings.php (modified) (history) (diff) /trunk/phase3/includes/Skin.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
—	—	@@ -1013,6 +1013,11 @@
1014	1014	$wgEnableSidebarCache = false;
1015	1015
1016	1016	/**
	1017	+ * Expiry time for the sidebar cache, in seconds
	1018	+ */
	1019	+$wgSidebarCacheExpiry = 86400;
	1020	+
	1021	+/**
1017	1022	* Under which condition should a page in the main namespace be counted
1018	1023	* as a valid article? If $wgUseCommaCount is set to true, it will be
1019	1024	* counted if it contains at least one comma. If it is set to false
Index: trunk/phase3/includes/Skin.php
—	—	@@ -1602,7 +1602,7 @@
1603	1603	* @private
1604	1604	*/
1605	1605	function buildSidebar() {
1606		~~- global $parserMemc, $wgEnableSidebarCache;~~
	1606	+ global $parserMemc, $wgEnableSidebarCache, $wgSidebarCacheExpiry;
1607	1607	global $wgLang, $wgContLang;
1608	1608
1609	1609	$fname = 'SkinTemplate::buildSidebar';
—	—	@@ -1663,7 +1663,7 @@
1664	1664	}
1665	1665	}
1666	1666	if ($cacheSidebar)
1667		~~- $parserMemc->set( $key, $bar, 86400 );~~
	1667	+ $parserMemc->set( $key, $bar, $wgSidebarCacheExpiry );
1668	1668	wfProfileOut( $fname );
1669	1669	return $bar;
1670	1670	}

15:24, 12 September 2011 Meno25 (talk | contribs) changed the status of r30736 [removed: ok added: old]