MediaWiki r29476 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r29475‎ | r29476 (on ViewVC)‎ | r29477 >
Date:02:18, 9 January 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 12505) Fixed section=0 with action=raw
PHP's fuzzy type comparisons strike again! A check for $this->mSection != '', probably intended to protect against an unset value, matched for integer values of 0 as well. (The fun part is that 0=='' and 0=='0' but '0'!='' :) Since the parameter is validated through getIntOrNull(), only the null check is necessary here.
Modified paths:

Diff [purge]

Loading diff…

Status & tagging log

  • 15:23, 12 September 2011 Meno25 (talk | contribs) changed the status of r29476 [removed: ok added: old]