MediaWiki r26591 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r26590‎ | r26591 (on ViewVC)‎ | r26592 >
Date:12:31, 11 October 2007
Author:catrope
Status:old
Tags:
Comment:
(bug 11612) Days to show in recent changes cannot be larger than 7
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/SpecialPreferences.php
===================================================================
--- trunk/phase3/includes/SpecialPreferences.php	(revision 26590)
+++ trunk/phase3/includes/SpecialPreferences.php	(revision 26591)
@@ -207,7 +207,7 @@
 	function savePreferences() {
 		global $wgUser, $wgOut, $wgParser;
 		global $wgEnableUserEmail, $wgEnableEmail;
-		global $wgEmailAuthentication;
+		global $wgEmailAuthentication, $wgRCMaxAge;
 		global $wgAuth, $wgEmailConfirmToEdit;
 
 
@@ -275,7 +275,7 @@
 		$wgUser->setOption( 'contextlines', $this->validateIntOrNull( $this->mSearchLines ) );
 		$wgUser->setOption( 'contextchars', $this->validateIntOrNull( $this->mSearchChars ) );
 		$wgUser->setOption( 'rclimit', $this->validateIntOrNull( $this->mRecent ) );
-		$wgUser->setOption( 'rcdays', $this->validateInt( $this->mRecentDays, 1, 7 ) );
+		$wgUser->setOption( 'rcdays', $this->validateInt($this->mRecentDays, 1, ceil($wgRCMaxAge / (3600*24))));
 		$wgUser->setOption( 'wllimit', $this->validateIntOrNull( $this->mWatchlistEdits, 0, 1000 ) );
 		$wgUser->setOption( 'rows', $this->validateInt( $this->mRows, 4, 1000 ) );
 		$wgUser->setOption( 'cols', $this->validateInt( $this->mCols, 4, 1000 ) );
Index: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	(revision 26590)
+++ trunk/phase3/RELEASE-NOTES	(revision 26591)
@@ -97,6 +97,7 @@
 * (bug 11620) Add call to User::isValidEmailAddr during accout creation.
 * (bug 11629) If $wgEmailConfirmToEdit is true, require people to supply an
   email address when registering.
+* (bug 11612) Days to show in recent changes cannot be larger than 7
 
 
 === API changes in 1.12 ===

Follow-up revisions

Rev.Commit summaryAuthorDate
r107169Bugzilla bug11612 - Make watchlist max days preference setting reflect the ma...bsitu18:55, 23 December 2011

Status & tagging log

  • 15:21, 12 September 2011 Meno25 (Talk | contribs) changed the status of r26591 [removed: ok added: old]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox