MediaWiki r25637 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r25636‎ | r25637 (on ViewVC)‎ | r25638 >
Date:13:52, 7 September 2007
Author:brion
Status:old
Tags:
Comment:
Some naming cleanup of the filename prefix blacklist added in r25620:
* Dropped a redundant if(count()) around a foreach().
* Renamed SpecialUpload::getFilenamePrefix() to getFilenamePrefixBlacklist(), since it returns a blacklist of filename prefixes, not the prefix of a filename. :)
* Renamed some local variables to match
* Renamed 'filename-prefix' message to 'filename-bad-prefix' and 'filename-prefix-list' to 'filename-prefix-blacklist' to clarify usage.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r25754Merged revisions 25607-25751 via svnmerge from...david23:02, 10 September 2007

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r25620* Add a warning for non-descriptive filenames at Special:Upload...raymond08:42, 7 September 2007

Status & tagging log

  • 15:20, 12 September 2011 Meno25 (talk | contribs) changed the status of r25637 [removed: ok added: old]