r22580 - Code Review

From MediaWiki.org

Repository:	MediaWiki
Revision:	< r22579 | r22580 (on ViewVC) | r22581 >
Date:	21:02, 30 May 2007
Author:	tstarling
Status:	new
Tags:
Comment:	Merged filerepo-work branch: * Added support for configuration of an arbitrary number of commons-style file repositories. * Split Image.php into filerepo/File.php and filerepo/LocalFile.php * Renamed Image::getImagePath() to File::getPath() * Added initial support for timestamp-based file fetching (OldLocalFile), to be expanded upon by aaron. * Changed the interface for Image/File object creation: use wfFindFile() or wfLocalFile() depending on semantics * ImageGallery::add() now accepts a title object as the first parameter * Moved file handling operations on upload from SpecialUpload to File * Removed path-related functions from ImageFunctions.php. Removed static path accessors from File. * Added a Content-Disposition header to thumb.php output * Improved thumb.php error handling * Updated the unit test suite to kind of partially work with modern computers. RunTests.php doesn't work just yet. Fixed an actual regression that the test suite detected -- moved some defines to Defines.php where they will be loaded consistently.
Modified paths:	/trunk/phase3/includes/AutoLoader.php (modified) (diff) /trunk/phase3/includes/CategoryPage.php (modified) (diff) /trunk/phase3/includes/DefaultSettings.php (modified) (diff) /trunk/phase3/includes/Defines.php (modified) (diff) /trunk/phase3/includes/ExternalEdit.php (modified) (diff) /trunk/phase3/includes/filerepo (added) /trunk/phase3/includes/filerepo (from /branches/filerepo-work/phase3/includes/filerepo:22570) (added) /trunk/phase3/includes/filerepo/LocalFile.php (modified) (diff) /trunk/phase3/includes/GlobalFunctions.php (modified) (diff) /trunk/phase3/includes/Image.php (deleted) /trunk/phase3/includes/ImageFunctions.php (modified) (diff) /trunk/phase3/includes/ImageGallery.php (modified) (diff) /trunk/phase3/includes/ImagePage.php (modified) (diff) /trunk/phase3/includes/ImageQueryPage.php (modified) (diff) /trunk/phase3/includes/Linker.php (modified) (diff) /trunk/phase3/includes/media/Bitmap.php (modified) (diff) /trunk/phase3/includes/media/DjVu.php (modified) (diff) /trunk/phase3/includes/media/Generic.php (modified) (diff) /trunk/phase3/includes/media/SVG.php (modified) (diff) /trunk/phase3/includes/MediaTransformOutput.php (modified) (diff) /trunk/phase3/includes/normal/UtfNormal.php (modified) (diff) /trunk/phase3/includes/Parser.php (modified) (diff) /trunk/phase3/includes/SearchEngine.php (modified) (diff) /trunk/phase3/includes/Setup.php (modified) (diff) /trunk/phase3/includes/Skin.php (modified) (diff) /trunk/phase3/includes/SpecialImagelist.php (modified) (diff) /trunk/phase3/includes/SpecialMIMEsearch.php (modified) (diff) /trunk/phase3/includes/SpecialNewimages.php (modified) (diff) /trunk/phase3/includes/SpecialUndelete.php (modified) (diff) /trunk/phase3/includes/SpecialUpload.php (modified) (diff) /trunk/phase3/includes/StreamFile.php (modified) (diff) /trunk/phase3/maintenance/cleanupImages.php (modified) (diff) /trunk/phase3/maintenance/FiveUpgrade.inc (modified) (diff) /trunk/phase3/maintenance/importImages.inc.php (modified) (diff) /trunk/phase3/maintenance/importImages.php (modified) (diff) /trunk/phase3/maintenance/rebuildImages.php (modified) (diff) /trunk/phase3/RELEASE-NOTES (modified) (diff) /trunk/phase3/StartProfiler.php (modified) (diff) /trunk/phase3/tests/ArticleTest.php (modified) (diff) /trunk/phase3/tests/DatabaseTest.php (modified) (diff) /trunk/phase3/tests/GlobalTest.php (modified) (diff) /trunk/phase3/tests/ImageFunctionsTest.php (added) /trunk/phase3/tests/ImageFunctionsTest.php (from /trunk/phase3/tests/ImageTest.php:22577) (added) /trunk/phase3/tests/ImageTest.php (deleted) /trunk/phase3/tests/README (modified) (diff) /trunk/phase3/tests/run-test.php (added) /trunk/phase3/tests/RunTests.php (modified) (diff) /trunk/phase3/tests/SanitizerTest.php (modified) (diff) /trunk/phase3/tests/SearchEngineTest.php (modified) (diff) /trunk/phase3/tests/SearchMySQL4Test.php (modified) (diff) /trunk/phase3/thumb.php (modified) (diff)

Follow-up revisions

Revision	Commit summary	Author	Date
r22587	Merged revisions 22555-22586 via svnmerge from	david	03:19, 31 May 2007