MediaWiki r19213 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r19212‎ | r19213 (on ViewVC)‎ | r19214 >
Date:22:29, 13 January 2007
Author:tstarling
Status:old
Tags:
Comment:
Removed broken __END__ feature.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/Parser.php
===================================================================
--- trunk/phase3/includes/Parser.php	(revision 19212)
+++ trunk/phase3/includes/Parser.php	(revision 19213)
@@ -3723,11 +3723,7 @@
 		}
 
 		# Trim trailing whitespace
-		# __END__ tag allows for trailing
-		# whitespace to be deliberately included
 		$text = rtrim( $text );
-		$mw =& MagicWord::get( 'end' );
-		$mw->matchAndRemove( $text );
 
 		return $text;
 	}
Index: trunk/phase3/languages/messages/MessagesEn.php
===================================================================
--- trunk/phase3/languages/messages/MessagesEn.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesEn.php	(revision 19213)
@@ -279,7 +279,6 @@
 	'msg'                    => array( 0,    'MSG:'                   ),
 	'subst'                  => array( 0,    'SUBST:'                 ),
 	'msgnw'                  => array( 0,    'MSGNW:'                 ),
-	'end'                    => array( 0,    '__END__'                ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb'     ),
 	'img_manualthumb'        => array( 1,    'thumbnail=$1', 'thumb=$1'),
 	'img_right'              => array( 1,    'right'                  ),
Index: trunk/phase3/languages/messages/MessagesYi.php
===================================================================
--- trunk/phase3/languages/messages/MessagesYi.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesYi.php	(revision 19213)
@@ -102,7 +102,6 @@
 	'msg'                    => array( 0,    'MSG:'                   ),
 	'subst'                  => array( 0,    'SUBST:'                 ),
 	'msgnw'                  => array( 0,    'MSGNW:'                 ),
-	'end'                    => array( 0,    '__END__'                ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb'     ),
 	'img_manualthumb'        => array( 1,    'thumbnail=$1', 'thumb=$1'),
 	'img_right'              => array( 1,    'right'                  ),
Index: trunk/phase3/languages/messages/MessagesVi.php
===================================================================
--- trunk/phase3/languages/messages/MessagesVi.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesVi.php	(revision 19213)
@@ -62,7 +62,6 @@
 	'msg'                    => array( 0,    'MSG:'     , 'NHẮN:'              ),
 	'subst'                  => array( 0,    'SUBST:'   ,  'THẾ:'            ),
 	'msgnw'                  => array( 0,    'MSGNW:'    ,  'NHẮNMỚI:'             ),
-	'end'                    => array( 0,    '__END__'    , '__KẾT__'            ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb' , 'nhỏ'    ),
 	'img_right'              => array( 1,    'right' , 'phải'                 ),
 	'img_left'               => array( 1,    'left'  , 'trái'                ),
Index: trunk/phase3/languages/messages/MessagesSr_el.php
===================================================================
--- trunk/phase3/languages/messages/MessagesSr_el.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesSr_el.php	(revision 19213)
@@ -159,7 +159,6 @@
 	'toc'                    => array( 0, '__TOC__', '__SADRŽAJ__' ),
 	'noeditsection'          => array( 0, '__NOEDITSECTION__', '__BEZ_IZMENA__', '__BEZIZMENA__' ),
 	'start'                  => array( 0, '__START__', '__POČETAK__' ),
-	'end'                    => array( 0, '__END__', '__KRAJ__' ),
 	'currentmonth'           => array( 1, 'CURRENTMONTH', 'TRENUTNIMESEC' ),
 	'currentmonthname'       => array( 1, 'CURRENTMONTHNAME', 'TRENUTNIMESECIME' ),
 	'currentmonthnamegen'    => array( 1, 'CURRENTMONTHNAMEGEN', 'TRENUTNIMESECGEN' ),
Index: trunk/phase3/languages/messages/MessagesCs.php
===================================================================
--- trunk/phase3/languages/messages/MessagesCs.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesCs.php	(revision 19213)
@@ -105,7 +105,6 @@
 	'msg'                    => array( 0,    'MSG:'                   ),
 	'subst'                  => array( 0,    'SUBST:',           'VLOŽIT:'            ),
 	'msgnw'                  => array( 0,    'MSGNW:',           'VLOŽITNW:'          ),
-	'end'                    => array( 0,    '__END__',          '__KONEC__'          ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb', 'náhled'           ),
 	'img_manualthumb'        => array( 1,    'thumbnail=$1', 'thumb=$1', 'náhled=$1'  ),
 	'img_right'              => array( 1,    'right',            'vpravo'             ),
Index: trunk/phase3/languages/messages/MessagesSk.php
===================================================================
--- trunk/phase3/languages/messages/MessagesSk.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesSk.php	(revision 19213)
@@ -100,7 +100,6 @@
 	'msg'   => array( 0, 'MSG:', 'SPRÁVA:' ),
 	'subst'   => array( 0, 'SUBST:' ),
 	'msgnw'   => array( 0, 'MSGNW:' ),
-	'end'   => array( 0, '__END__', '__KONIEC__' ),
 	'img_thumbnail'   => array( 1, 'thumbnail', 'thumb', 'náhľad', 'náhľadobrázka' ),
 	'img_right'   => array( 1, 'right', 'vpravo' ),
 	'img_left'   => array( 1, 'left', 'vľavo' ),
Index: trunk/phase3/languages/messages/MessagesHe.php
===================================================================
--- trunk/phase3/languages/messages/MessagesHe.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesHe.php	(revision 19213)
@@ -112,7 +112,6 @@
 	'msg'                   => array( 0,    'הכללה:',                                'MSG:'                   ),
 	'subst'                 => array( 0,    'ס:',                                    'SUBST:'                 ),
 	'msgnw'                 => array( 0,    'הכללת מקור',                            'MSGNW:'                 ),
-	'end'                   => array( 0,    '__סוף__',                               '__END__'                ),
 	'img_thumbnail'         => array( 1,    'ממוזער',                                'thumbnail', 'thumb'     ),
 	'img_manualthumb'       => array( 1,    'ממוזער=$1',                             'thumbnail=$1', 'thumb=$1'),
 	'img_right'             => array( 1,    'ימין',                                  'right'                  ),
Index: trunk/phase3/languages/messages/MessagesTt.php
===================================================================
--- trunk/phase3/languages/messages/MessagesTt.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesTt.php	(revision 19213)
@@ -66,7 +66,6 @@
         'namespace'              => array( 1,    'İSEMARA',                'NAMESPACE'),
         'subst'                  => array( 0,    'TÖPÇEK:',                'SUBST:'),
         'msgnw'                  => array( 0,    'MSGNW:'                 ),
-        'end'                    => array( 0,    '__AZAQ__',               '__END__'),
         'img_thumbnail'          => array( 1,    'thumbnail', 'thumb'     ),
         'img_right'              => array( 1,    'uñda',                   'right'),
         'img_left'               => array( 1,    'sulda',                  'left'),
Index: trunk/phase3/languages/messages/MessagesAr.php
===================================================================
--- trunk/phase3/languages/messages/MessagesAr.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesAr.php	(revision 19213)
@@ -66,7 +66,6 @@
 	'msg'                    => array( 0,    'MSG:'         ,          'رسالة:'          ),
 	'subst'                  => array( 0,    'SUBST:'      ,     'نسخ:'  , 'نسخ_قالب:'   ),
 	'msgnw'                  => array( 0,    'MSGNW:'     ,  'مصدر:' , 'مصدر_قالب:'      ),
-	'end'                    => array( 0,    '__END__'       ,  '__نهاية__', '__إنهاء__'   ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb'   ,          'تصغير'    ),
 	'img_manualthumb'        => array( 1,    'thumbnail=$1', 'thumb=$1'  ,'تصغير=$1'      ),
 	'img_right'              => array( 1,    'right'       ,       'يمين'                  ),
Index: trunk/phase3/languages/messages/MessagesBe.php
===================================================================
--- trunk/phase3/languages/messages/MessagesBe.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesBe.php	(revision 19213)
@@ -81,7 +81,6 @@
 	'msg'                    => array( 0,    'MSG:', 'ПАВЕДАМЛЕНЬНЕ:' ),
 	'subst'                  => array( 0,    'SUBST:', 'ПАДСТАНОЎКА:' ),
 	'msgnw'                  => array( 0,    'MSGNW:', 'ПАВЕДАМЛЕНЬНЕ_БЯЗЬ_ВІКІ:' ),
-	'end'                    => array( 0,    '__END__', '__КАНЕЦ__' ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb', 'значак', 'міні' ),
 	'img_manualthumb'        => array( 1,    'thumbnail=$1', 'thumb=$1', 'значак=$1', 'міні=$1' ),
 	'img_right'              => array( 1,    'right', 'справа' ),
Index: trunk/phase3/languages/messages/MessagesBg.php
===================================================================
--- trunk/phase3/languages/messages/MessagesBg.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesBg.php	(revision 19213)
@@ -70,7 +70,6 @@
 	'namespace'              => array( 1, 'NAMESPACE', 'ИМЕННОПРОСТРАНСТВО'   ),
 	'subst'                  => array( 0, 'SUBST:', 'ЗАМЕСТ:'            ),
 	'msgnw'                  => array( 0, 'MSGNW:', 'СЪОБЩNW:'           ),
-	'end'                    => array( 0, '__END__', '__КРАЙ__'            ),
 	'img_thumbnail'          => array( 1, 'thumbnail', 'thumb', 'мини'     ),
 	'img_manualthumb'        => array( 1, 'thumbnail=$1', 'thumb=$1', 'мини=$1'),
 	'img_right'              => array( 1, 'right', 'вдясно', 'дясно', 'д'  ),
Index: trunk/phase3/languages/messages/MessagesBs.php
===================================================================
--- trunk/phase3/languages/messages/MessagesBs.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesBs.php	(revision 19213)
@@ -37,7 +37,6 @@
 	'toc'                    => array( 0, '__TOC__', '__SADRŽAJ__' ),
 	'noeditsection'          => array( 0, '__NOEDITSECTION__', '__BEZ_IZMENA__', '__BEZIZMENA__' ),
 	'start'                  => array( 0, '__START__', '__POČETAK__' ),
-	'end'                    => array( 0, '__END__', '__KRAJ__' ),
 	'currentmonth'           => array( 1, 'CURRENTMONTH', 'TRENUTNIMJESEC' ),
 	'currentmonthname'       => array( 1, 'CURRENTMONTHNAME', 'TRENUTNIMJESECIME' ),
 	'currentmonthnamegen'    => array( 1, 'CURRENTMONTHNAMEGEN', 'TRENUTNIMJESECROD' ),
Index: trunk/phase3/languages/messages/MessagesNn.php
===================================================================
--- trunk/phase3/languages/messages/MessagesNn.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesNn.php	(revision 19213)
@@ -105,7 +105,6 @@
 	'namespace'              => array( 1,    'NAMESPACE', 'NAMNEROM', 'NAVNEROM'                                    ),
 	'subst'                  => array( 0,    'SUBST:', 'LIMINN:'                                                    ),
 	'msgnw'                  => array( 0,    'MSGNW:', 'IKWIKMELD:'                                                 ),
-	'end'                    => array( 0,    '__END__', '__SLUTT__'                                                 ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb', 'mini', 'miniatyr'                               ),
 	'img_manualthumb'        => array( 1,    'thumbnail=$1', 'thumb=$1', 'mini=$1', 'miniatyr=$1'                   ),
 	'img_right'              => array( 1,    'right', 'høgre', 'høyre'                                              ),
Index: trunk/phase3/languages/messages/MessagesRo.php
===================================================================
--- trunk/phase3/languages/messages/MessagesRo.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesRo.php	(revision 19213)
@@ -29,7 +29,6 @@
 	'currentmonthnamegen'    => array( 1,    'CURRENTMONTHNAMEGEN', '{{NUMELUNACURENTAGEN}}'   ),
 	'subst'                  => array( 0,    'SUBST:'                                          ),
 	'msgnw'                  => array( 0,    'MSGNW:', 'MSJNOU:'                               ),
-	'end'                    => array( 0,    '__END__', '__FINAL__'                            ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb'                              ),
 	'img_right'              => array( 1,    'right'                                           ),
 	'img_left'               => array( 1,    'left'                                            ),
Index: trunk/phase3/languages/messages/MessagesRu.php
===================================================================
--- trunk/phase3/languages/messages/MessagesRu.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesRu.php	(revision 19213)
@@ -146,7 +146,6 @@
 	'msg'                    => array( 0,    'MSG:', 'СООБЩ:'),
 	'subst'                  => array( 0,    'SUBST:','ПОДСТ:'),
 	'msgnw'                  => array( 0,    'MSGNW:', 'СООБЩ_БЕЗ_ВИКИ:'),
-	'end'                    => array( 0,    '__END__','__КОНЕЦ__'),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb', 'мини'),
 	'img_manualthumb'        => array( 1,    'thumbnail=$1', 'thumb=$1', 'мини=$1'),
 	'img_right'              => array( 1,    'right','справа'),
Index: trunk/phase3/languages/messages/MessagesGa.php
===================================================================
--- trunk/phase3/languages/messages/MessagesGa.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesGa.php	(revision 19213)
@@ -46,7 +46,6 @@
 	'msg'                    => array( 0,    'MSG:',                 'TCHT:'  ),
 	'subst'                  => array( 0,    'SUBST:',               'IONAD:'  ),
 	'msgnw'                  => array( 0,    'MSGNW:',               'TCHTFS:'  ),
-	'end'                    => array( 0,    '__END__',              '__DEIREADH__'  ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb',   'mionsamhail', 'mion'  ),
 	'img_right'              => array( 1,    'right',                'deas'  ),
 	'img_left'               => array( 1,    'left',                 'clé'  ),
Index: trunk/phase3/languages/messages/MessagesSr_ec.php
===================================================================
--- trunk/phase3/languages/messages/MessagesSr_ec.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesSr_ec.php	(revision 19213)
@@ -157,7 +157,6 @@
 	'toc'                    => array( 0, '__TOC__', '__САДРЖАЈ__' ),
 	'noeditsection'          => array( 0, '__NOEDITSECTION__', '__БЕЗ_ИЗМЕНА__', '__БЕЗИЗМЕНА__' ),
 	'start'                  => array( 0, '__START__', '__ПОЧЕТАК__' ),
-	'end'                    => array( 0, '__END__', '__КРАЈ__' ),
 	'currentmonth'           => array( 1, 'CURRENTMONTH', 'ТРЕНУТНИМЕСЕЦ' ),
 	'currentmonthname'       => array( 1, 'CURRENTMONTHNAME', 'ТРЕНУТНИМЕСЕЦИМЕ' ),
 	'currentmonthnamegen'    => array( 1, 'CURRENTMONTHNAMEGEN', 'ТРЕНУТНИМЕСЕЦГЕН' ),
Index: trunk/phase3/languages/messages/MessagesNds.php
===================================================================
--- trunk/phase3/languages/messages/MessagesNds.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesNds.php	(revision 19213)
@@ -30,7 +30,6 @@
 	'namespace'              => array( 1, 'NAMESPACE',                   'NAAMRUUM'               ),
 	'subst'                  => array( 0, 'SUBST:'                                                ),
 	'msgnw'                  => array( 0, 'MSGNW:'                                                ),
-	'end'                    => array( 0, '__END__',                     '__ENN__'                ),
 	'img_thumbnail'          => array( 1, 'thumbnail', 'thumb',          'duum'                   ),
 	'img_right'              => array( 1, 'right',                       'rechts'                 ),
 	'img_left'               => array( 1, 'left',                        'links'                  ),
Index: trunk/phase3/languages/messages/MessagesPt.php
===================================================================
--- trunk/phase3/languages/messages/MessagesPt.php	(revision 19212)
+++ trunk/phase3/languages/messages/MessagesPt.php	(revision 19213)
@@ -88,7 +88,6 @@
 	'msg'                    => array( 0,    'MSG:'                   ),
 	'subst'                  => array( 0,    'SUBST:'                 ),
 	'msgnw'                  => array( 0,    'MSGNW:'                 ),
-	'end'                    => array( 0,    '__END__'                ),
 	'img_thumbnail'          => array( 1,    'thumbnail', 'thumb'     ),
 	'img_manualthumb'        => array( 1,    'thumbnail=$1', 'thumb=$1'),
 	'img_right'              => array( 1,    'right', 'direita'       ),
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox