MediaWiki r19195 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r19194‎ | r19195 (on ViewVC)‎ | r19196 >
Date:04:25, 13 January 2007
Author:brion
Status:old
Tags:
Comment:
* Add 'purge' privilege to replace the hardcoded check for login state in
determining whether action=purge can be done via GET. Switching the
permission on for anons can be helpful for benchmarking.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/Article.php
===================================================================
--- trunk/phase3/includes/Article.php	(revision 19194)
+++ trunk/phase3/includes/Article.php	(revision 19195)
@@ -911,7 +911,7 @@
 	function purge() {
 		global $wgUser, $wgRequest, $wgOut;
 
-		if ( $wgUser->isLoggedIn() || $wgRequest->wasPosted() ) {
+		if ( $wgUser->isAllowed( 'purge' ) || $wgRequest->wasPosted() ) {
 			if( wfRunHooks( 'ArticlePurge', array( &$this ) ) ) {
 				$this->doPurge();
 			}
Index: trunk/phase3/includes/DefaultSettings.php
===================================================================
--- trunk/phase3/includes/DefaultSettings.php	(revision 19194)
+++ trunk/phase3/includes/DefaultSettings.php	(revision 19195)
@@ -964,6 +964,7 @@
 $wgGroupPermissions['user' ]['reupload']        = true;
 $wgGroupPermissions['user' ]['reupload-shared'] = true;
 $wgGroupPermissions['user' ]['minoredit']       = true;
+$wgGroupPermissions['user' ]['purge']           = true; // can use ?action=purge without clicking "ok"
 
 // Implicit group for accounts that pass $wgAutoConfirmAge
 $wgGroupPermissions['autoconfirmed']['autoconfirmed'] = true;
Index: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	(revision 19194)
+++ trunk/phase3/RELEASE-NOTES	(revision 19195)
@@ -59,6 +59,9 @@
 * (bug 8613) Fix error when viewing "Recent Changes" and using Postgres.
 * Initialise site_stats table at upgrade time if data was missing
 * (bug 7250) Updated Unicode normalization tables to Unicode 5.0
+* Add 'purge' privilege to replace the hardcoded check for login state in
+  determining whether action=purge can be done via GET. Switching the
+  permission on for anons can be helpful for benchmarking.
 
 
 == Languages updated ==
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox