MediaWiki r15384 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r15383‎ | r15384 (on ViewVC)‎ | r15385 >
Date:17:33, 6 July 2006
Author:robchurch
Status:old
Tags:
Comment:
* Implicit group "emailconfirmed" for all users whose email addresses are confirmed
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -773,6 +773,17 @@
774774 if( $accountAge >= $wgAutoConfirmAge ) {
775775 $implicitGroups[] = 'autoconfirmed';
776776 }
 777+
 778+ # Implicit group for users whose email addresses are confirmed
 779+ global $wgEmailAuthentication;
 780+ if( $this->isValidEmailAddr( $this->mEmail ) ) {
 781+ if( $wgEmailAuthentication ) {
 782+ if( $this->mEmailAuthenticated )
 783+ $implicitGroups[] = 'emailconfirmed';
 784+ } else {
 785+ $implicitGroups[] = 'emailconfirmed';
 786+ }
 787+ }
777788
778789 $effectiveGroups = array_merge( $implicitGroups, $this->mGroups );
779790 $this->mRights = $this->getGroupPermissions( $effectiveGroups );
Index: trunk/phase3/includes/DefaultSettings.php
@@ -882,6 +882,10 @@
883883 // Implicit group for accounts that pass $wgAutoConfirmAge
884884 $wgGroupPermissions['autoconfirmed']['autoconfirmed'] = true;
885885
 886+// Implicit group for accounts with confirmed email addresses
 887+// This has little use when email address confirmation is off
 888+$wgGroupPermissions['emailconfirmed']['emailconfirmed'] = true;
 889+
886890 // Users with bot privilege can have their edits hidden
887891 // from various log pages by default
888892 $wgGroupPermissions['bot' ]['bot'] = true;
Index: trunk/phase3/RELEASE-NOTES
@@ -652,8 +652,8 @@
653653 * (bug 6560) Avoid PHP notice when trimming ISBN whitespace
654654 * Added namespace translation to Kannada (ka)
655655 * (bug 6566) Improve input validation on timestamp conversion
 656+* Implicit group "emailconfirmed" for all users whose email addresses are confirmed
656657
657 -
658658 == Compatibility ==
659659
660660 MediaWiki 1.7 requires PHP 5 (5.1 recommended). PHP 4 is no longer supported.