MediaWiki r13105 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r13104‎ | r13105 (on ViewVC)‎ | r13106 >
Date:13:47, 25 February 2006
Author:midom
Status:old
Tags:
Comment:
allow to disable schema checks - those acquire giant locks on table opens..
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/Image.php
===================================================================
--- trunk/phase3/includes/Image.php	(revision 13104)
+++ trunk/phase3/includes/Image.php	(revision 13105)
@@ -1244,6 +1244,10 @@
 	}
 
 	function checkDBSchema(&$db) {
+                global $wgCheckDBSchema;
+		if (!$wgCheckDBSchema) {
+			return;
+		}
 		# img_name must be unique
 		if ( !$db->indexUnique( 'image', 'img_name' ) && !$db->indexExists('image','PRIMARY') ) {
 			wfDebugDieBacktrace( 'Database schema not up to date, please run maintenance/archives/patch-image_name_unique.sql' );
Index: trunk/phase3/includes/DefaultSettings.php
===================================================================
--- trunk/phase3/includes/DefaultSettings.php	(revision 13104)
+++ trunk/phase3/includes/DefaultSettings.php	(revision 13105)
@@ -432,6 +432,8 @@
 $wgDBschema	    = 'mediawiki';
 /**#@-*/
 
+/** Live high performance sites should disable this - some checks acquire giant mysql locks */
+$wgCheckDBSchema = true;
 
 
 /**

Follow-up revisions

Rev.Commit summaryAuthorDate
r63911Remove ancient (added in r13105) stopgap to prevent running schema sanity che...demon16:03, 18 March 2010

Status & tagging log

  • 01:58, 13 October 2010 ^demon (Talk | contribs) changed the status of r13105 [removed: new added: old]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox