MediaWiki r12542 - Code Review

Repository:	MediaWiki
Revision:	< r12541‎ \| r12542 (on ViewVC)‎ \| r12543 >
Date:	10:45, 9 January 2006
Author:	midom
Status:	old
Tags:
Comment:	move hardcoded ParserCache expire time to DefaultSettings.php, 1 day now
Modified paths:	/trunk/phase3/includes/DefaultSettings.php (modified) (history) (diff) /trunk/phase3/includes/ParserCache.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
—	—	@@ -524,6 +524,8 @@
525	525	$wgMessageCacheType = CACHE_ANYTHING;
526	526	$wgParserCacheType = CACHE_ANYTHING;
527	527
	528	+$wgParserCacheExpireTime = 86400;
	529	+
528	530	$wgSessionsInMemcached = false;
529	531	$wgLinkCacheMemcached = false; # Not fully tested
530	532
Index: trunk/phase3/includes/ParserCache.php
—	—	@@ -93,6 +93,7 @@
94	94	}
95	95
96	96	function save( $parserOutput, &$article, &$user ){
	97	+ global $wgParserCacheExpireTime;
97	98	$key = $this->getKey( $article, $user );
98	99	$now = wfTimestampNow();
99	100	$parserOutput->setCacheTime( $now );
—	—	@@ -102,7 +103,7 @@
103	104	if( $parserOutput->containsOldMagic() ){
104	105	$expire = 3600; # 1 hour
105	106	} else {
106		~~- $expire = 86400; # 1 day~~
	107	+ $expire = $wgParserCacheExpireTime;
107	108	}
108	109	$this->mMemc->set( $key, $parserOutput, $expire );
109	110	}

01:58, 13 October 2010 ^demon (talk | contribs) changed the status of r12542 [removed: new added: old]