MediaWiki r114959 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:< r114958‎ | r114959 (on ViewVC)‎ | r114960 >
Date:21:15, 18 April 2012
Author:catrope
Status:ok
Tags:
Comment:
Followup r114956: make the regexes consistent between checkoutMediawiki and deleteMediawiki
Modified paths:

Diff [purge]

Index: trunk/tools/mwmultiversion/multiversion/deleteMediaWiki
——@@ -16,7 +16,7 @@
1717 $argsValid = false;
1818 if ( count( $argv ) >= 2 ) {
1919 $dstVersion = $argv[1]; // e.g. "php-X.XXwmfX"
20 - if ( preg_match( '/^php-((?:\d+\.\d+wmf\d+|master)(?:-\w+)?)$/', $dstVersion, $m ) ) {
 20+ if ( preg_match( '/^php-(\d+\.\d+wmf\d+|master)$/', $dstVersion, $m ) ) {
2121 $dstVersionNum = $m[1]; // everything after 'php-'
2222 $argsValid = true;
2323 }

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r114956Update scripts for the new php-1.XXwmfX naming patterncatrope17:32, 18 April 2012

Status & tagging log

Retrieved from "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114959"