MediaWiki r112573 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r112572‎ | r112573 (on ViewVC)‎ | r112574 >
Date:03:17, 28 February 2012
Author:krinkle
Status:ok (Comments)
Tags:tstarling 
Comment:
[mediawiki.action.edit] Clean up and bug fixes
* Bugfix: Locally alias the toolbar object and replace usage of 'this' with 'toolbar'. Calls to window.addButton were failing due to it referring to the dynamic 'this' context which changes when the function is a member of a different object.
* Bugfux: Move currentFocused = $( '#wpTextbox1' ) into the dom-ready hook. When executed before dom-ready the element doesn't exist yet. r111983 did this for $toolbar, but not for currentFocused (bug 34538)

* Move onReady and isReady to the local scope (introduced recently in r111983, not used or meant to be used publicly)
* Merge onReady with the $(document).ready hook function, same purpose
* JS conventions (closure arguments, var hoisting, whitespace)


* Touch r111983, r112451, r112567
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r113174MFT r111795, r111881, r111920, r112573, r112995, r113169reedy20:12, 6 March 2012
r113175MFT r111795, r111881, r111920, r112573, r112995, r113169reedy20:13, 6 March 2012

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r111983* Fixed failure of the edit toolbar to load when $wgResourceLoaderExperimenta...tstarling23:29, 20 February 2012
r111984Bug 34538 again. Bug reproduced and fix tested.tstarling23:47, 20 February 2012
r111985* Fixed load order like bug 34538...tstarling00:00, 21 February 2012
r111989* (bug 34538) Fixed compatibility with $wgResourceLoaderExperimentalAsyncLoad...tstarling04:03, 21 February 2012
r112451* Fix r111983 (bug 34662): make mw.toolbar.addButton() work even after DOM ready...tstarling22:46, 26 February 2012
r112462(bug 34538) Fixed compatibility with $wgResourceLoaderExperimentalAsyncLoadin...tstarling00:56, 27 February 2012
r112567Fix scoping in r112451: isReady was accidentally used as a global variablecatrope02:36, 28 February 2012

Comments

#Comment by Reedy (talk | contribs)   17:58, 6 March 2012

Presumably this should be tagged 1.19wmf1 also?

Status & tagging log

  • 20:13, 6 March 2012 Reedy (talk | contribs) changed the tags for r112573 [removed: 1.19,1.19wmf1]
  • 19:21, 6 March 2012 Brion VIBBER (talk | contribs) changed the status of r112573 [removed: new added: ok]
  • 18:48, 6 March 2012 Krinkle (talk | contribs) changed the tags for r112573 [added: 1.19wmf1]
  • 16:37, 28 February 2012 Hashar (talk | contribs) changed the tags for r112573 [added: 1.19,tstarling]