MediaWiki r112451 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r112450‎ | r112451 (on ViewVC)‎ | r112452 >
Date:22:46, 26 February 2012
Author:tstarling
Status:resolved (Comments)
Tags:
Comment:
* Fix r111983 (bug 34662): make mw.toolbar.addButton() work even after DOM ready
* Don't use an empty array as the default for $toolbar, use false which will throw an exception on a logic error.
* Fix exception handling in mw.loader: have handlePending() rethrow its exception so that the exception handler in execute() can run, so that the exception gets logged. But don't rethrow the exception in execute(), because that may break other modules.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r112456Release notes for added feature in r112451 which fixed bug 33952krinkle23:47, 26 February 2012
r112567Fix scoping in r112451: isReady was accidentally used as a global variablecatrope02:36, 28 February 2012
r1125701.19wmf1: MFT r111983, r112384, r112451, r112561, r112562, r112567catrope02:55, 28 February 2012
r112573[mediawiki.action.edit] Clean up and bug fixes...krinkle03:17, 28 February 2012
r112647MFT r112384, r112400, r112408, r112451, r112456, r112474, r112526, r112533, r...reedy21:21, 28 February 2012

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r88392Changing console.log(e) to a throw. console.log makes it go toString() which ...krinkle20:31, 18 May 2011
r111983* Fixed failure of the edit toolbar to load when $wgResourceLoaderExperimenta...tstarling23:29, 20 February 2012

Comments

#Comment by Wikinaut (talk | contribs)   23:44, 26 February 2012

this fixes at least bug34662 "no toolbar (editbar) icons in trunk since r111983" (closed now).

Status & tagging log

  • 21:21, 28 February 2012 Reedy (talk | contribs) changed the tags for r112451 [removed: 1.19]
  • 02:57, 28 February 2012 Catrope (talk | contribs) changed the tags for r112451 [removed: 1.19wmf1]
  • 02:37, 28 February 2012 Catrope (talk | contribs) changed the status of r112451 [removed: new added: resolved]
  • 23:43, 26 February 2012 Krinkle (talk | contribs) changed the tags for r112451 [added: 1.19,1.19wmf1]