MediaWiki r111983 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r111982‎ | r111983 (on ViewVC)‎ | r111984 >
Date:23:29, 20 February 2012
Author:tstarling
Status:resolved (Comments)
Tags:
Comment:
* Fixed failure of the edit toolbar to load when $wgResourceLoaderExperimentalAsyncLoading is enabled and module execution occurs before the edit box appears in the DOM. Similar to bug 34538.
* Also fixed breakage of byteLimit on edit in the same scenario.
* For 1.19 backport so no release notes.
Modified paths:

Diff [purge]

Loading diff…

Sign-offs

UserFlagDate
Nikerabbitinspected09:13, 21 February 2012
Krinkleinspected23:44, 26 February 2012

Follow-up revisions

Rev.Commit summaryAuthorDate
r111984Bug 34538 again. Bug reproduced and fix tested.tstarling23:47, 20 February 2012
r111985* Fixed load order like bug 34538...tstarling00:00, 21 February 2012
r111989* (bug 34538) Fixed compatibility with $wgResourceLoaderExperimentalAsyncLoad...tstarling04:03, 21 February 2012
r112451* Fix r111983 (bug 34662): make mw.toolbar.addButton() work even after DOM ready...tstarling22:46, 26 February 2012
r112462(bug 34538) Fixed compatibility with $wgResourceLoaderExperimentalAsyncLoadin...tstarling00:56, 27 February 2012
r1125701.19wmf1: MFT r111983, r112384, r112451, r112561, r112562, r112567catrope02:55, 28 February 2012
r112573[mediawiki.action.edit] Clean up and bug fixes...krinkle03:17, 28 February 2012
r112637MFT r111380, r111809, r111983, r112034, r112037, r112152reedy21:02, 28 February 2012

Comments

#Comment by Krinkle (talk | contribs)   21:31, 22 February 2012

Same as in r111989 cr, $toolbar : [],

#Comment by Hashar (talk | contribs)   13:32, 24 February 2012

cause bug 34662 : classic toolbar does not load :-/

#Comment by Wikinaut (talk | contribs)   20:17, 26 February 2012

this should be reverted, as it breaks -at least- editbar (toolbar) loading (see bug34662 ), perhaps other things.

#Comment by Tim Starling (talk | contribs)   01:11, 27 February 2012

Fixed in r112451.

Status & tagging log

  • 21:02, 28 February 2012 Reedy (talk | contribs) changed the tags for r111983 [removed: 1.19]
  • 02:57, 28 February 2012 Catrope (talk | contribs) changed the tags for r111983 [removed: 1.19wmf1]
  • 02:46, 28 February 2012 Catrope (talk | contribs) changed the status of r111983 [removed: new added: resolved]
  • 23:43, 26 February 2012 Krinkle (talk | contribs) changed the tags for r111983 [added: 1.19,1.19wmf1]
  • 22:47, 26 February 2012 Tim Starling (talk | contribs) changed the status of r111983 [removed: fixme added: new]
  • 13:32, 24 February 2012 Hashar (talk | contribs) changed the status of r111983 [removed: ok added: fixme]
  • 21:31, 22 February 2012 Krinkle (talk | contribs) changed the status of r111983 [removed: new added: ok]