MediaWiki r108115 - Code Review

Repository:	MediaWiki
Revision:	< r108114‎ \| r108115 (on ViewVC)‎ \| r108116 >
Date:	04:53, 5 January 2012
Author:	mah
Status:	ok (Comments)
Tags:
Comment:	Bug 33514 - Make category "columns" (table cells) equal width Author: Erwin Dokter
Modified paths:	/trunk/phase3/includes/CategoryViewer.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/CategoryViewer.php
—	—	@@ -486,10 +486,11 @@
487	487	# Split into three columns
488	488	$columns = array_chunk( $columns, ceil( count( $columns ) / 3 ), true /* preserve keys */ );
489	489
490		~~- $ret = '<table width="100%"><tr valign="top"><td>';~~
	490	+ $ret = '<table width="100%"><tr valign="top">';
491	491	$prevchar = null;
492	492
493	493	foreach ( $columns as $column ) {
	494	+ $ret .= '<td width="33.3%">';
494	495	$colContents = array();
495	496
496	497	# Kind of like array_flip() here, but we keep duplicates in an
—	—	@@ -519,10 +520,10 @@
520	521	$prevchar = $char;
521	522	}
522	523
523		~~- $ret .= "</td>\n<td>";~~
	524	+ $ret .= "</td>\n";
524	525	}
525	526
526		~~- $ret .= '</td></tr></table>';~~
	527	+ $ret .= '</tr></table>';
527	528	return $ret;
528	529	}
529	530

User	Flag	Date
Nikerabbit	inspected	10:11, 5 January 2012

#Comment by Hashar (Talk | contribs) 10:27, 5 January 2012

Nikerabbit, I am not sure why you marked this one new :-D

#Comment by Nikerabbit (Talk | contribs) 10:29, 5 January 2012

Because I keep tabs open for a while and CR doesn't detect conflicts.

00:51, 18 January 2012 Siebrand (Talk | contribs) changed the tags for r108115 [removed: core]
10:26, 5 January 2012 Hashar (Talk | contribs) changed the status of r108115 [removed: new added: ok]
10:11, 5 January 2012 Nikerabbit (Talk | contribs) changed the status of r108115 [removed: ok added: new]
09:01, 5 January 2012 Hashar (Talk | contribs) changed the status of r108115 [removed: new added: ok]
05:47, 5 January 2012 RobLa-WMF (Talk | contribs) changed the tags for r108115 [added: core]