MediaWiki r103761 - Code Review

Repository:	MediaWiki
Revision:	< r103760‎ \| r103761 (on ViewVC)‎ \| r103762 >
Date:	15:02, 20 November 2011
Author:	catrope
Status:	ok
Tags:
Comment:	(bug 32451) Clicking on a special characters section loses the selection in IE8. Patch by Lupo
Modified paths:	/trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js (modified) (history) (diff)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
—	—	@@ -438,13 +438,13 @@
439	439	}
440	440	},
441	441	buildBookmark : function( context, id, page ) {
442		~~- var label = $.wikiEditor.autoMsg( page,~~
443		~~- 'label' );~~
	442	+ var label = $.wikiEditor.autoMsg( page, 'label' );
444	443	return $( '<div/>' )
445	444	.text( label )
446	445	.attr( 'rel', id )
447	446	.data( 'context', context )
448	447	.mousedown( function( e ) {
	448	+ context.fn.saveCursorAndScrollTop();
449	449	// No dragging!
450	450	e.preventDefault();
451	451	return false;
—	—	@@ -464,6 +464,7 @@
465	465	if ( $.trackAction !== undefined){
466	466	$.trackAction(section + '.' + $(this).attr('rel'));
467	467	}
	468	+ context.fn.restoreCursorAndScrollTop();
468	469	// No dragging!
469	470	event.preventDefault();
470	471	return false;
—	—	@@ -488,7 +489,7 @@
489	490	html += $.wikiEditor.modules.toolbar.fn.buildRow( context, page.rows[i] );
490	491	}
491	492	}
492		~~- $page.html( html );~~
	493	+ $page.html( html + '</table>');
493	494	break;
494	495	case 'characters':
495	496	$page.addClass( 'page-characters' );

15:25, 14 January 2012 Siebrand (Talk | contribs) changed the tags for r103761 [removed: miscextensions]
15:09, 12 January 2012 ^demon (Talk | contribs) changed the status of r103761 [removed: new added: ok]
06:38, 5 January 2012 RobLa-WMF (Talk | contribs) changed the tags for r103761 [added: miscextensions]