MediaWiki r103362 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r103361‎ | r103362 (on ViewVC)‎ | r103363 >
Date:19:50, 16 November 2011
Author:bawolff
Status:ok
Tags:
Comment:
(bug 31535; bug 332) Properly truncate upload summaries (img_description) on the php side.

Before it would get truncated when inserted into the 255 byte db field. This is bad as it can leave dangling multi-byte unicode sequences, additionally, since directly after upload we appearently cache the file object, this can result in the comment in the file history table being super-huge.

This also removes the parenthesis in the comment field in the table. Its a table, we don't need to use () to visually separate it from the rest of the page content.

This commit also causes '...' (or the i18n'ed equivalent) to be appended when truncated a comment. Previously that didn't happen. Also I changed it to use a method that doesn't check for '*' as a special value to mean no description. I looked at the toolserver db, and even uploads to enwikipedia from 2002 don't use '*' as special no-description marker.
Modified paths:

Diff [purge]

Loading diff…

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r40837Fix for bug #332 - all UTF-8 output is now cleaned of invalid forms as define...krimpet00:42, 15 September 2008
r40840Release notes for bug #332krimpet01:37, 15 September 2008
r40861Revert r40837, r40839, r40840 (bug 332 - broken UTF-8)...brion17:51, 15 September 2008

Status & tagging log

  • 09:58, 15 December 2011 Nikerabbit (talk | contribs) changed the status of r103362 [removed: new added: ok]