MediaWiki r10228 - Code Review

Repository:	MediaWiki
Revision:	< r10227‎ \| r10228 (on ViewVC)‎ \| r10229 >
Date:	20:52, 21 July 2005
Author:	avar
Status:	old
Tags:
Comment:	* Make makeInternalOrExternalUrl() use the same url protocols as the parser
Modified paths:	/trunk/phase3/includes/Skin.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
—	—	@@ -1247,7 +1247,7 @@
1248	1248	# If url string starts with http, consider as external URL, else
1249	1249	# internal
1250	1250	/static/ function makeInternalOrExternalUrl( $name ) {
1251		~~- if ( strncmp( $name, 'http', 4 ) == 0 ) {~~
	1251	+ if ( preg_match( '/^(?:' . URL_PROTOCOLS . ')/', $name ) ) {
1252	1252	return $name;
1253	1253	} else {
1254	1254	return $this->makeUrl( $name );

01:58, 13 October 2010 ^demon (Talk | contribs) changed the status of r10228 [removed: new added: old]