MediaWiki r10075 - Code Review

Repository:	MediaWiki
Revision:	< r10074‎ \| r10075 (on ViewVC)‎ \| r10076 >
Date:	01:05, 13 July 2005
Author:	avar
Status:	old
Tags:
Comment:	* The url is now optional
Modified paths:	/trunk/phase3/includes/DefaultSettings.php (modified) (history) (diff) /trunk/phase3/includes/SpecialVersion.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
—	—	@@ -1226,8 +1226,8 @@
1227	1227	$wgSkinExtensionFunctions = array();
1228	1228	$wgExtensionFunctions = array();
1229	1229	/**
1230		~~- * An array of extension types, their authors, url and name, add to it from~~
1231		~~- * an extension like:~~
	1230	+ * An array of extension names, their authors, and optionally, urls
	1231	+ * add to it from an extension like:
1232	1232	*
1233	1233	* <code>
1234	1234	* $wgExtensionCredits[$type][] = array(
Index: trunk/phase3/includes/SpecialVersion.php
—	—	@@ -53,7 +53,13 @@
54	54	if ( count( @$wgExtensionCredits[$type] ) > 0 ) {
55	55	$out .= "=== $text ===\n";
56	56	foreach ( $wgExtensionCredits[$type] as $extension ) {
57		~~- $out .= '* [' . $extension['url'] . ' ' . $extension['name'] . '] by ' . $extension['author'] . "\n";~~
	57	+ if ( isset( $extension['url'] ) ) {
	58	+ $out .= '* [' . $extension['url'] . ' ' . $extension['name'] . ']';
	59	+ } else {
	60	+ $out .= '* ' . $extension['name'];
	61	+ }
	62	+ $out .= ' by ' . $extension['author'] . "\n";
	63	+
58	64	}
59	65	}
60	66

01:58, 13 October 2010 ^demon (Talk | contribs) changed the status of r10075 [removed: new added: old]