MediaWiki r100312 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r100311‎ | r100312 (on ViewVC)‎ | r100313 >
Date:01:01, 20 October 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Followup r100310, one more thing
Modified paths:

Diff [purge]

Index: trunk/extensions/CheckUser/api/ApiQueryCheckUser.php
@@ -66,10 +66,9 @@
6767 }
6868
6969 $resultIPs = array();
70 - foreach ( array_keys( $ips ) as $ip ) {
71 - $newIp = $ips[$ip];
72 - $newIp['address'] = $ip;
73 - $resultIPs[] = $newIp;
 70+ foreach ( $ips as $ip => $data ) {
 71+ $data['address'] = $ip;
 72+ $resultIPs[] = $data;
7473 }
7574
7675 CheckUser::addLogEntry( 'userips', 'user', $target, $reason, $user_id );

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r100310Clean up some odd loopingjohnduhart00:59, 20 October 2011

Status & tagging log

  • 16:35, 21 December 2011 Catrope (talk | contribs) changed the status of r100312 [removed: new added: ok]