Gerrit/Project ownership

From MediaWiki.org
Jump to: navigation, search

This page queues individuals' requests to be added to the Gerrit project owner groups for specific Gerrit projects (each of which corresponds to a Git repository). A Gerrit project owner has the power to approve changes for merger into that Gerrit project's master branch, and to veto changes (see +2).

"When/how we'll add, remove people from Gerrit project owner groups" has procedural details. Sumana Harihareswara will regularly look at new requests for project owner membership and contact the existing project owners. If there is consensus from the existing project owners, then we'll approve the candidate. For each new candidate the process shouldn't take more than two weeks, and usually much less. Ownership can be revoked.

If your codebase/extension/tool isn't in Git yet, use this form to create a new Gerrit project: Gerrit/New repositories

To see the current list of Gerrit project owners for a specific Gerrit project, visit https://gerrit.wikimedia.org/r/#/admin/groups/ .

Ownership structure[edit | edit source]

Example: an extension is named foo.

  • The Gerrit group "foo" should usually be an owner of the Gerrit project "foo."
  • Sometimes, meta-groups will be included in the group. This is for people have ownership over multiple extensions, so you can add/remove members in one place.
  • Rights to the group may be inherited from other groups (Look for a "Rights Inherit From:" in the project access.)

Specific example: the project "mediawiki/extensions/DonationInterface" is owned by group "extension-DonationInterface." This group includes the meta-group "fundraising." Also members of the group "mediawiki" has ownership via "Rights Inherit From: "mediawiki/extensions access"

By keeping the naming convention ("extensions/foo" is owned by group "extension-foo"), it'll make the "automatically setup a repo" process much more scriptable when we hit that bridge.

(Note to Gerrit group creators: remember to check the "Make group visible to all registered users." checkbox.)

To make a new Project Owner[edit | edit source]

MediaWiki core[edit | edit source]

We are maintaining a "WMF" branch of mediawiki/core.git. We use submodules for deployed extensions, and can pull from master as regularly as we want for deployments. At the start of the migration to git, the project owners of this branch are going to be the people who have the ability to deploy code to Wikimedia Foundation servers. gerrit will offer a list of the "Gerrit project owners" for this branch, except for the Operations (system administration) group, which is an LDAP group. Every member of the Wikimedia Foundation operations team will also be in the Gerrit project owners group insofar as they have code review rights globally, but in practice will rarely review code. We may add some existing code reviewers to this Gerrit project owners group. Details; you can request to be added.

At the start of the migration, this list of Gerrit project owners for the WMF branch is also the list of Gerrit project owners for the master branch. However, eventually, we will add to the list of Gerrit project owners for master, using as criteria the number and quality of developers' previous commits and code reviews.

Details and procedure for adding and removing people from the Gerrit project owners groups.

MediaWiki has release branches (19 so far) for core, and master (the default branch previously known as "trunk" in SVN). Example: [1] ("heads" is gitweb's term for branches). MediaWiki core and WMF-deployed extensions will be tagging releases just as we did in Subversion, except they'll be Git tags instead of SVN tags. Any other extension will make its own decisions regarding tagging.

MediaWiki extensions that the Wikimedia Foundation deploys[edit | edit source]

Same procedure as for MediaWiki core, and the same Gerrit project owner groups.

Other MediaWiki extensions[edit | edit source]

Every extension author can choose between two choices here for non-master branches: the gated-trunk/push-for-review model, and a straight push model. For any given extension, we will honor the wishes of the person/s listed as the main author on the extension's mediawiki.org page.

The gated-trunk/push-for-review is the model that we are using for MediaWiki core, as mentioned above. A Gerrit project owners group (plus the above mentioned Gerrit project owners group for MediaWiki core) will be able to "+2" (approve and merge) changes to their extensions. The extension author(s) will be able to define a Gerrit project owners group and add others to it.
The straight push model is similar to how we did things in Subversion; anyone can suggest a change and submit a pull request, and it will automatically be approved and merged.

Master branches must go through Gerrit and cannot be straight push. This is necessary to facilitate a number of Gerrit features, including replication, updating of the extension meta-repository, and ability of Translatewiki to provide localization updates.

We could define groups to make this easier for batches of extensions (e.g. SMW developers). Chad will offer your community a choice. Please let Chad what you would like via Git/New repositories.

Other Gerrit projects[edit | edit source]

Same procedure as for "other MediaWiki extensions" above.

Requests[edit | edit source]

An archive box Archives 

Archive

Add a request

Wikinaut for extension UserMerge[edit | edit source]

update: I think my request has been forgotten. I hereby re-apply for becoming UserMerge maintainer. I was that before the extension was moved from SVN to git, but then it was forgotten to set me up again as owner for the git version. --Wikinaut (talk) 18:07, 5 January 2014 (UTC)

previous discussion

Hereby I apply gerrit project ownership for the extension UserMerge, which I maintain since a while see https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/UserMerge and Extension:UserMerge. Further projects which I already maintain since a long time are OpenID, AJAXPoll, EtherpadLite, RSS, WikiArticleFeeds.

To support my request: there is a relationship between UserMerge and OpenID for example, when merging/deleting an account. I also added the needed hook some time ago to mw core.

--Wikinaut (talk) 19:18, 30 May 2013 (UTC)

  • Support Support Bawolff (talk) 22:51, 3 June 2013 (UTC)
  • Weak Oppose Oppose - I've worked with Wikinaut a bit on Extension:OpenID. He's a diligent maintainer, but he tends to do a lot of self +2ing. While I don't mind this much in most extensions, it seems Extension:UserMerge is deployed to WMF wikis (specifically WikiVoyage). I would support this if somebody else was added to the project with him. Parent5446 (talk) 03:01, 4 June 2013 (UTC)
@Parent: the +2ing was at least in some cases done after having had security chats with Ryan and CSteipp - who gave their "ok, go on". Just as a comment. --Wikinaut (talk) 19:28, 4 June 2013 (UTC)
In my opinion, +2'ing is ok if he's the only maintainer (or there is agreement among the maintainers that that is ok), and the extension is not being used by WMF. I don't see anything wrong with non-wmf extensions using different code review strategies (+2'ing is of course never ok on WMF extensions). Bawolff (talk) 21:04, 13 June 2013 (UTC)
  • Weak Oppose Oppose I was just witness to an instance where Wikinaut asked for advice, implemented the solution incorrectly, then self-merged. When someone else is involved in a change it's almost certainly important to wait for some followup feedback. That said I can't strong-oppose since it was basically an extension he builds on his own, hence "weak". --MarkTraceur (talk) 00:51, 5 June 2013 (UTC)
  • Oppose Oppose In my view not yet experienced enough in web development (PHP/JS) and MediaWiki-specific interfaces to review and approve code changes to Wikimedia-deployed software. Krinkle (talk) 04:42, 9 June 2013 (UTC)
  • Support Support I think the opposes above carry no value to this discussion and should be ignored. Wikinaut is among the main authors of the extension and probably the only person interested in maintaining it as of now (there are no true owners: [2]): not being given ownership upon creation of this repo is just a remnant of the past. The fact that this extension is marginally enabled on some WMF wikis can't stop its development: if WMF doesn't trust the extension/its maintainer(s), WMF should just disable it from Wikivoyage. It's always been a dangerous extension, that should not be normally present on WMF wikis anyway, and was enabled only to assist the temporary needs of migration: but that was a year ago! --Nemo 18:15, 5 January 2014 (UTC)

Aude +2 for wikimedia/wikimania-scholarships[edit | edit source]

Aude is listed as a member of the project and the owner of the GitHub project that the current application was forked from. She has recently been granted +2 on mediawiki/core and I believe that it should be an uncontroversial decision to allow her to the same rights on this project. --BDavis (WMF) (talk) 18:37, 20 December 2013 (UTC)

Support Support Legoktm (talk) 16:26, 14 January 2014 (UTC)
Support Support seems obvious --MarkTraceur (talk) 18:28, 14 January 2014 (UTC)
Support Support Experienced contributor in general, and since she started the project, she clearly has experience here. Superm401 - Talk 20:01, 27 January 2014 (UTC)

aarcos +2 for UploadWizard[edit | edit source]

User:aaron_arcos has been working with the Multimedia team on Extension:MultimediaViewer, we gave him +2 on it last month (see the section above), but now he's moved on to working on Extension:UploadWizard and it would be good to give him +2 on that too. --MarkTraceur (talk) 18:55, 9 January 2014 (UTC)

Isarra for mediawiki/skins[edit | edit source]

Isarra is a skilled designer and ShoutWiki's current design/UX person. She's written several nifty skins on her own as well as collaborated with other developers (most notably yours truly) on various design and UX matters. I'm absolutely confident in her skills and therefore it'd only make sense for such an expert to belong to the mediawiki/skins group. --Jack Phoenix (Contact) 22:23, 9 January 2014 (UTC)

Support Support Matma Rex (talk) 22:54, 9 January 2014 (UTC)
Support Support Legoktm (talk) 16:26, 14 January 2014 (UTC)
Support Support of course. Isarra has been a tireless and sometimes underappreciated force in the design sphere of MediaWiki. Giving her more ability to effect change in the skins would definitely be useful! --MarkTraceur (talk) 16:39, 14 January 2014 (UTC)
Support Support per MarkTraceur Yuvipanda (talk) 18:19, 14 January 2014 (UTC)
Support Support --Krenair (talkcontribs) 18:13, 14 January 2014 (UTC)
Support Support clearly has relevant experience. Steven Walling (WMF) • talk 22:14, 14 January 2014 (UTC)

Is there any reason this hasn't gone through yet? --MarkTraceur (talk) 18:45, 22 January 2014 (UTC)

Sam Smith (phuedx) to staff group[edit | edit source]

Sam Smith (phuedx on-wiki, Gerrit, and IRC, samsmith@wikimedia.org) is a new staff member in Features Engineering/the Growth team.[3] Please add him to the staff group? Thanks, Steven Walling (WMF) • talk 23:39, 24 January 2014 (UTC)

Addshore for mediawiki/core[edit | edit source]

Addshore is a longtime Wikipedian who is now a MediaWiki contributor, working on the Wikidata team. He's also contributed a lot to core (merged patches), especially in the area of writing unit tests. I think him having +2 will be beneficial. Legoktm (talk) 22:10, 25 January 2014 (UTC)

  • Support Support Matma Rex (talk) 17:51, 27 January 2014 (UTC)
  • Support Support he has submitted numerous core patches, improving test coverage [4], etc. (in addition to work on Wikibase and various other extensions) Aude (talk) 02:11, 28 January 2014 (UTC)
  • Support Support I've had great interactions with Addshore when it comes to software work, including on applications like Huggle. Seems like a 'low risk, high potential for doing good' candidate for core. Steven Walling (WMF) • talk 23:22, 31 January 2014 (UTC)
  • Support Support - Hoo man (talk) 23:07, 3 February 2014 (UTC)
  • Support Support -- Duesentrieb 23:01, 7 February 2014 (UTC)
  • YesY Done added to mediawiki group ^demon[omg plz] 05:25, 20 February 2014 (UTC)

Shahyar (username SG) to staff group[edit | edit source]

Shahyar is a new team member on the Flow project. EBernhardson (WMF) (talk) 00:06, 29 January 2014 (UTC)

Shahyar Ghobadpour (SG on-wiki, Gerrit, and shahyar in IRC, sghobadpour@wikimedia.org) is a new staff member in Features Engineering/the Core Features team. Please add him to the staff group? EBernhardson (WMF) (talk) 19:41, 30 January 2014 (UTC)

Shahyar should probably just be added to the staff group. Steven Walling (WMF) • talk 03:59, 29 January 2014 (UTC)
Support Support Tychay (talk) 18:27, 31 January 2014 (UTC)
  • YesY Done added to ldap/wmf group ^demon[omg plz] 05:25, 20 February 2014 (UTC)

mglaser for +2[edit | edit source]

Markus needs this to tag code and push version # changes. And he has otherwise earned it. -- MarkAHershberger(talk) 22:52, 29 January 2014 (UTC)

Support Support - Hoo man (talk) 23:07, 3 February 2014 (UTC)

Add AndyRussG to the owners group for extension/Workflow[edit | edit source]

He is working on this code with me and should have merge privileges. Thanks!

Support Support Also, does AndyRussG have staff rights? If not, he should. Tychay (talk) 18:28, 31 January 2014 (UTC)
Support Support adding him to the staff group. AndyRussG is working full time as a contractor for us now, and will likely need merge rights in a variety of extensions/config. Steven Walling (WMF) • talk 04:52, 11 February 2014 (UTC)
  • YesY Done added to ldap/wmf group ^demon[omg plz] 05:25, 20 February 2014 (UTC)

Add Cindy.cicalese to the ownership group for the SemanticTitle extension[edit | edit source]

This extension is no longer actively maintained by the original author. However, it is in need of enhancement. Cindy Cicalese is actively using an updated version of this extension on a variety of wikis. She made a presentation on this topic at the Fall 2013 SMWCon where there was considerable interest in the evolution of the extension to fix its current deficiencies and support for this request.

Support Support Experienced developer, and my understanding is that the author of SemanticTitle, Van de Bugger, has been incommunicado for a while now. Yaron Koren (talk) 18:51, 19 February 2014 (UTC)
Support Support Cindy have created several great extensions and I'm sure SemanticTitle will benefit from her effort. Katkov Yury
Support Support We are looking forward to having Cindy's good work integrated in SemanticTitle. Ad Strack van Schijndel
  • YesY Done added to extension-SemanticTitle ^demon[omg plz] 05:25, 20 February 2014 (UTC)

Emufarmers for ConfirmEdit[edit | edit source]

As we all know, combating spam is one of the main pain points of running a public wiki. It seems quine inappropriate to me that ConfirmEdit, our main antispam solution, has no specific maintainers and several useful patches rotting for years.
Emufarmers is the author of the most useful captcha module for "normal" wikis, QuestyCaptcha; well integrated in the developers community; very helpful in users support on this wiki, mailing lists and elsewhere; and has agreed (clap clap) to co-mentor "Multilingual, usable and effective captchas", for which we have at least one interested GSoC applicant (and hopefully more). I hope he can be added to owners of the extension. --Nemo 11:47, 22 February 2014 (UTC)

Support Support :) Legoktm (talk) 07:12, 23 February 2014 (UTC)
Support Support Yay for someone to take it over! --brion (talk) 18:08, 31 March 2014 (UTC)
YesY Done ^demon[omg plz] 22:18, 26 June 2014 (UTC)
Updated [5] at last. --Nemo 06:49, 27 June 2014 (UTC)

dr0ptp4kt (Firefox OS)[edit | edit source]

I, dr0ptp4kt, would like +2 Publish and Submit rights on apps/firefox/wikipedia. Yuri Astrakhan and I maintain the Firefox OS Wikipedia app and will steer its "reboot". This access will allow Yuri and I to better free up Brion. Yuri and I have an established workflow for code review and merge-deploy. --ABaso(WMF) (talk) 17:56, 31 March 2014 (UTC)

Support Support --brion (talk) 18:07, 31 March 2014 (UTC)
Seems to have already been YesY Done ^demon[omg plz] 22:18, 26 June 2014 (UTC)

yurik (Firefox OS)[edit | edit source]

I nominate yurik for +2 Publish and Submit rights on apps/firefox/wikipedia. Yuri Astrakhan and I maintain the Firefox OS Wikipedia app and will steer its "reboot". This access will allow Yuri and I to better free up Brion. Yuri and I have an established workflow for code review and merge-deploy. --ABaso(WMF) (talk) 17:57, 31 March 2014 (UTC)

Support Support --brion (talk) 18:07, 31 March 2014 (UTC)
YesY Done ^demon[omg plz] 22:18, 26 June 2014 (UTC)

dr0ptp4kt (Wikipedia for iOS)[edit | edit source]

I, dr0ptp4kt, would like +2 Publish and Submit rights on apps/ios/wikipedia. I perform code review and add code to the Wikipedia for iOS app. This access will allow me to merge lower risk patchsets, freeing up Brion, and also merge moderate risk patchsets if Brion is out and we're in a pinch. Brion, Monte, and I follow routine code review and merge-deploy procedures. --ABaso(WMF) (talk) 18:00, 31 March 2014 (UTC)

Support Support --brion (talk) 18:07, 31 March 2014 (UTC)
YesY Done ^demon[omg plz] 22:18, 26 June 2014 (UTC)

mhurd (Wikipedia for iOS)[edit | edit source]

Need to get Monte Hurd (mhurd) set up with +2 rights on apps/ios/wikipedia. Or maybe provide permission bits through some other channel entirely. We're not really sure? --brion (talk) 19:08, 21 April 2014 (UTC)

YesY Done ^demon[omg plz] 22:18, 26 June 2014 (UTC)

devunt for LogoFunctions[edit | edit source]

I'm author of LogoFunctions extension. And I need ownership of this project in gerrit to contribute a some patches. --devunt (talk) 06:37, 30 May 2014 (UTC)

YesY Done ^demon[omg plz] 22:18, 26 June 2014 (UTC)

wmf-deployment +2 for tgr[edit | edit source]

I got deployment rights recently (RT #7527) but apparently I am not in wmf-deployment; this is mostly a problem when preparing SWAT patches, according to the new policy I should create a submodule update changeset, and merge the backports in the extension repo myself, but extensions inherit the mediawiki setting that only wmf-deployment has +2 for wmf/* branches, so I cannot do that. --Tgr (WMF) (talk) 23:24, 4 June 2014 (UTC)

Support Support Greg (WMF) (talk) 23:05, 24 June 2014 (UTC)
Support Support BDavis (WMF) (talk) 23:07, 24 June 2014 (UTC)
YesY Done ^demon[omg plz] 22:19, 26 June 2014 (UTC)

Arlo Breault (Arlolra) to staff group[edit | edit source]

Arlo Breault (arlolra on-wiki, Gerrit, and IRC, abreault@wikimedia.org) has been a staff member in Features Engineering/the Parsoid team for over a year now. Please add him to the staff group? Thanks, Gabriel Wicke (GWicke) (talk) 19:24, 24 June 2014 (UTC)

Support Support Greg (WMF) (talk) 23:05, 24 June 2014 (UTC)
Support Support Tychay (talk) 19:20, 25 June 2014 (UTC)
YesY Done ^demon[omg plz] 22:20, 26 June 2014 (UTC)

Marc Ordinas i Llopis (marcoil) to staff group[edit | edit source]

Marc Ordinas i Llopis (marcoil on-wiki, Gerrit, and IRC, marcoil@wikimedia.org) has been a staff member in Features Engineering/the Parsoid team for a long time now. Please add him to the staff group? Thanks, Gabriel Wicke (GWicke) (talk) 19:24, 24 June 2014 (UTC)

Support Support Greg (WMF) (talk) 23:05, 24 June 2014 (UTC)
Support Support Tychay (talk) 19:21, 25 June 2014 (UTC) (this should be automatic since he's been staff for quite some time)
YesY Done ^demon[omg plz] 22:20, 26 June 2014 (UTC)

Yaron Koren for ownership of Contributors extension[edit | edit source]

I would like ownership privileges for the Contributors extension. This extension was created by Rob Church and seems to have been abandoned (other than generic maintenance changes) in around 2009. I would like to add some features to it, without impacting the existing functionality. My development username is "yaron". Yaron Koren (talk) 12:46, 25 June 2014 (UTC)

YesY Done ^demon[omg plz] 22:22, 26 June 2014 (UTC)

jackmcbarn for +2 in mediawiki[edit | edit source]

Jack has been contributing a lot to core, specifically in the area of the Parser. He's also contributed to various extensions, including more parser related work in Scribunto. I think him having +2 would be helpful. Merged patches. Legoktm (talk) 22:12, 26 June 2014 (UTC)

Support Support Ssastry (talk) 19:51, 9 July 2014 (UTC)
Support Support Gabriel Wicke (GWicke) (talk) 19:56, 9 July 2014 (UTC)
Support Support Matma Rex (talk) 20:31, 9 July 2014 (UTC)
Support Support Parent5446 (talk) 02:48, 10 July 2014 (UTC)
Support Support, I trust him to only sign off things he can sign off - Hoo man (talk) 08:36, 10 July 2014 (UTC)

Deepali Jain for ownership of BookManagerv2 extension[edit | edit source]

I would like to request ownership privileges for the BookManagerv2 extension. I am working on BookManagerv2 as my GSoC 2014 project. I am the primary contributor to the project right now. I have completed some major features and working on some more. The features are being tested simultaneously on wmflabs server. Patches Jaindeepali (talk) 08:33, 5 July 2014 (UTC)

PleaseStand for +2 for mediawiki/*[edit | edit source]

I find PleaseStand highly clueful and helpful. He's fairly active in Gerrit (merged changes) and I think he would be able to even more efficiently and effectively contribute and help out with +2 rights for mediawiki/*. I trust him to know when and when not to merge changes. Respectfully submitted for consideration. --MZMcBride (talk) 04:10, 22 July 2014 (UTC)

Support Support I learned a lot from PleaseStand. Ori.livneh (talk) 05:00, 22 July 2014 (UTC)
Support Support Matma Rex (talk) 12:53, 22 July 2014 (UTC)
Support Support Legoktm (talk) 19:15, 22 July 2014 (UTC)