Gerrit/Project ownership

From MediaWiki.org
Jump to: navigation, search

Gerrit project owners have the power to approve changes for merger into their Gerrit project's master branch, and to veto changes (see +2). The current list of Gerrit project owners can be found in https://gerrit.wikimedia.org/r/#/admin/groups/

If your codebase/extension/tool isn't in Gerrit yet, use this form to create a new Gerrit project: Gerrit/New repositories

Ownership structure[edit | edit source]

Example: an extension is named foo.

  • The Gerrit group "foo" should usually be an owner of the Gerrit project "foo".
  • Sometimes, meta-groups will be included in the group. This is for people have ownership over multiple extensions, so you can add/remove members in one place.
  • Rights to the group may be inherited from other groups (Look for a "Rights Inherit From:" in the project access.)

Specific example: the project "mediawiki/extensions/DonationInterface" is owned by group "extension-DonationInterface." This group includes the meta-group "fundraising." Also members of the group "mediawiki" has ownership via "Rights Inherit From: "mediawiki/extensions access"

By keeping the naming convention ("extensions/foo" is owned by group "extension-foo"), it'll make the "automatically setup a repo" process much more scriptable when we hit that bridge.

(Note to Gerrit group creators: remember to check the "Make group visible to all registered users." checkbox.)

Requesting repository ownership[edit | edit source]

In order to request repository ownership, you need to create a new task under the Repository-Ownership-Requests project in Phabricator, specifying

  • Gerrit username
  • repository or repositories to be owned
  • reasoning

If there is consensus from the existing project owners, any of the Gerrit group creators can resolve the request, after following the process described below. For each new candidate the process shouldn't take more than two weeks, and usually much less. Ownership can be revoked.

To make a new Project Owner[edit | edit source]

"When/how we'll add, remove people from Gerrit project owner groups" has procedural details.

MediaWiki core[edit | edit source]

We are maintaining a "WMF" branch of mediawiki/core.git. We use submodules for deployed extensions, and can pull from master as regularly as we want for deployments. At the start of the migration to git, the project owners of this branch are going to be the people who have the ability to deploy code to Wikimedia Foundation servers. gerrit will offer a list of the "Gerrit project owners" for this branch, except for the Operations (system administration) group, which is an LDAP group. Every member of the Wikimedia Foundation operations team will also be in the Gerrit project owners group insofar as they have code review rights globally, but in practice will rarely review code. We may add some existing code reviewers to this Gerrit project owners group. Details; you can request to be added.

At the start of the migration, this list of Gerrit project owners for the WMF branch is also the list of Gerrit project owners for the master branch. However, eventually, we will add to the list of Gerrit project owners for master, using as criteria the number and quality of developers' previous commits and code reviews.

Details and procedure for adding and removing people from the Gerrit project owners groups.

MediaWiki has release branches (19 so far) for core, and master (the default branch previously known as "trunk" in SVN). Example: [1] ("heads" is gitweb's term for branches). MediaWiki core and WMF-deployed extensions will be tagging releases just as we did in Subversion, except they'll be Git tags instead of SVN tags. Any other extension will make its own decisions regarding tagging.

MediaWiki extensions that the Wikimedia Foundation deploys[edit | edit source]

Same procedure as for MediaWiki core, and the same Gerrit project owner groups.

Other MediaWiki extensions[edit | edit source]

Every extension author can choose between two choices here for non-master branches: the gated-trunk/push-for-review model, and a straight push model. For any given extension, we will honor the wishes of the person/s listed as the main author on the extension's mediawiki.org page.

The gated-trunk/push-for-review is the model that we are using for MediaWiki core, as mentioned above. A Gerrit project owners group (plus the above mentioned Gerrit project owners group for MediaWiki core) will be able to "+2" (approve and merge) changes to their extensions. The extension author(s) will be able to define a Gerrit project owners group and add others to it.
The straight push model is similar to how we did things in Subversion; anyone can suggest a change and submit a pull request, and it will automatically be approved and merged.

Master branches must go through Gerrit and cannot be straight push. This is necessary to facilitate a number of Gerrit features, including replication, updating of the extension meta-repository, and ability of Translatewiki to provide localization updates.

We could define groups to make this easier for batches of extensions (e.g. SMW developers). Chad will offer your community a choice. Please let Chad what you would like via Git/New repositories.

Other Gerrit projects[edit | edit source]

Same procedure as for "other MediaWiki extensions" above.

Archived requests[edit | edit source]

Requests handled on-wiki before the migration of this process to Phabricator can be found under Archive.