Extension talk:LocalisationUpdate

Some comments:

+siebrand> LocalisationUpdate.php should be smaller, and you should lazy load from class files.
+Nikerabbit> the sql should probably be hooked to LoadExtensionSchemaUpdates, it doesn't seem to support table prefixes
+Nikerabbit> I also don't like that it creates a new entry point, either write a command line scripts, a special page or both
+Nikerabbit> how does it determine which updates are compatible and which are not?
+Nikerabbit> $query = "select value from localisation where identifier = '".$db->strencode($lckey)."' and language = '".$db->strencode($langcode)."'";
+Nikerabbit> we have nice $db->select() for this :)
+Nikerabbit> I also see some code duplication there

– Nikerabbit 07:25, 20 May 2009 (UTC)

+Nikerabbit> any reason not to use preg_foo?

Done --TheDevilOnLine 07:50, 20 May 2009 (UTC)

+Nikerabbit> can you use Http::get instead of curl directly?

Done --TheDevilOnLine 07:50, 20 May 2009 (UTC)

update database

• when a message is changed or removed from the local messagefile (in English) will the localisation be removed from the database ?
• when a message is changed in SVN, will the localisation be saved for as long as the local message has not changed ?

Thanks, GerardM 22:27, 20 May 2009 (UTC)

two issues left

I have been asked by Naoko to write the two issues that need some more work.

• The performance of the software took a hit when some work was done to make the software more safe.
  • Tom's plan is to talk to Brion and ask for his advise
• When a language known in the Names.php is new to the localisation of an extension, it needs to be introduced in the database.

Thanks, GerardM 07:53, 22 July 2009 (UTC)

Get errors when run update script

When I ran php extensions/LocalisationUpdate/update.php on the command line, I got the following errors:

PHP Catchable fatal error:  Argument 4 passed to LocalisationUpdate::compareFiles() must be an array, boolean given, called in /srv/www/w.ray.io/public_html/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 163 and defined in /srv/www/w.ray.io/public_html/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 305

--Sparanoid 07:44, 12 September 2011 (UTC)