Extension talk:Flash Extension

Thanks for this fine extension! But there is a little bug in your flash.php:

Instead of:

          </param><embed src="$url" type="application/x-shockwave-flash" width=425 height=350></embed></object>

it must be

          </param><embed src="$url" type="application/x-shockwave-flash" width="$width" height="$height"></embed></object>

Otherwise one cannot set the width and height in the <swf> tag ;)

-- PyroM 10:08, 22 January 2007 (UTC)

there is another bug (same as before)

instead of

<object width="425" height="350">

it must be

<object width="$width" height="$height">

Nameless 04/05/07

Completely rigth!! Thanks for your bugfixing. I've fixed it in wikis's php code

Internet expolorer issue (Flash needs a click)

Is there any way to write a Flash/embedded object so that it doesnt require the extra click that Internet explorer does? The regular non-mediawiki way to do that is using a document.write. --Kenny5 02:04, 4 September 2007 (UTC)

In 2007 Kenny asked about the possibility to embed it. Still seems to be the case by the end of 2009, using FF. It is a step into the right direction, but would be better if I really could embed it.

Mindboggling

if ( strpos($input , "http") === 0 && strpos($input, ".swf") == strlen($input)-4 ) {

This row is wrong in so many ways. It fails on http://www.swf.com/file.swf but also on more dangerous ones such as http://example.com/virus.exe#.swf It's completely the wrong approach. You should at least check with a regular expression, so you get more control over the input. Besides, this part's just ugly:

strpos($input, ".swf") == strlen($input)-4

It would be more efficient to do:

substr($input, -4) == '.swf'

(but that is of course still the wrong approach). --217.70.32.102 09:49, 4 February 2010 (UTC) //Emil V