Extension talk:FlaggedRevs

From MediaWiki.org
Jump to: navigation, search
Start a new discussion

Contents

Thread titleRepliesLast modified
Special:SpecialPages708:21, 8 February 2012
Draw the stable Image on stable pages011:37, 25 January 2012
After approved not show images and return broken link to file. Only to unregistered user.621:01, 13 January 2012
Mass Sight102:21, 10 January 2012
Error for /maintenance/updateStats.php - "Notice: Undefined variable: times" + Misc206:50, 6 January 2012
Revisions remains the same even if included templates are changed 201:24, 3 January 2012
How to use Special:PendingChanges100:56, 10 December 2011
Help with skin100:55, 10 December 2011
chmod o+w extensions/FlaggedRevs/client100:54, 10 December 2011
Merging pending contributions?100:52, 10 December 2011
Prevent picture page to show also unapproved versions100:51, 10 December 2011
Comment in history100:44, 10 December 2011
New pages marked as unreviewed by default?100:42, 10 December 2011
Basic Settings Misleading100:38, 3 December 2011
Enable editor for comments120:41, 30 November 2011
Banner in the print version320:38, 30 November 2011
Get a list of random reviewed pages with the API ?016:14, 10 November 2011
FlaggedRevs + Semantic MediaWiki issue013:20, 17 October 2011
How to make stable version by default ?111:57, 22 August 2011
Disabling automatic sight009:22, 15 August 2011

Special:SpecialPages

I'm don't can use Special:SpecialPages after instalation of FlaggedRevs - Special:SpecialPages. This page shows "The website has a programming error.". Other pages as I see works. What is programming error can be. This is for the new site [1]. May by that is compability error Version. For this time I exclude FlaggedRevs. Page Special:SpecialPages after that are work. What I can do. FlaggedRevs in this site is needed. And. FlaggedRevs/maintenance/updateStats.php return "Invalid entry". Please help. Thanks.

Vpovilaitis18:04, 26 January 2012

Look at the PHP error log (often in the apache error log).

Aaron00:12, 31 January 2012

Thanks. I'm found for Special:SpecialPages that was needed more memory. But when I execute FlaggedRevs/maintenance/updateStats.php, I'm receiving "Invalid entry".

Vpovilaitis17:30, 1 February 2012

I'd need to know more about what the error looks like. I don't recognize "Invalid entry".

Aaron02:05, 2 February 2012

I'm comment in file extensions/FlaggedRevs/maintenance/updateStats.inc lines:

/*if ( php_sapi_name() != 'cli' ) {
        print( 'Invalid entry' );
        die( 1 );
}*/

after that. I'm receive:

Content-type: text/html

ValidationStatistics A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: http://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script Query: SELECT MIN(rev_timestamp) AS rt,MIN(n.fr_timestamp) AS nft,MAX(p.fr_rev_id) FROM `encrevision` INNER JOIN `encflaggedrevs` `p` FORCE INDEX (PRIMARY) ON ((p.fr_page_id = rev_page) AND (p.fr_rev_id < rev_id) AND (p.fr_timestamp < rev_timestamp)) INNER JOIN `encflaggedrevs` `n` FORCE INDEX (PRIMARY) ON ((n.fr_page_id = rev_page) AND (n.fr_rev_id >= rev_id) AND (n.fr_timestamp >= rev_timestamp)) WHERE rev_user = '0' AND (rev_timestamp BETWEEN '20120126223222' AND '20120207112002') AND ((rev_id % 1) = 0) GROUP BY rev_id Function: FlaggedRevsStats::getReviewTimesAnons Error: 1104 The SELECT would examine more than MAX_JOIN_SIZE rows; check your WHERE and use SET SQL_BIG_SELECTS=1 or SET MAX_JOIN_SIZE=# if the SELECT is okay (localhost)

Vpovilaitis12:29, 7 February 2012

Yes. This sql has error. Full scan is needed for this sql. Must be changed index witch must be used in this sql.

Vpovilaitis20:47, 7 February 2012
 

I'm change extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php fragment to (change using index PRIMARY to page_rev):

                # For edits that started off pending, how long do they take to get reviewed?
                # Edits started off pending if made when a flagged rev of the page already existed.
                # Get the *first* reviewed rev *after* each edit and get the time difference.
                $res = $dbr->select(
                        array( 'revision', 'p' => 'flaggedrevs', 'n' => 'flaggedrevs' ),
                        array( 'MIN(rev_timestamp) AS rt', 'MIN(n.fr_timestamp) AS nft', 'MAX(p.fr_rev_id)' ),
                        array( 'rev_user' => 0, $timeCondition, "(rev_id % $mod) = 0" ),
                        __METHOD__,
                        array(
                                'GROUP BY'      => 'rev_id',
                                'USE INDEX' => array( 'p' => 'page_rev', 'n' => 'page_rev' )
                                #'USE INDEX' => array( 'p' => 'PRIMARY', 'n' => 'PRIMARY' )
                        ),
                        array(
                                'p' => array( 'INNER JOIN', array( // last review INNER
                                        'p.fr_page_id = rev_page',
                                        'p.fr_rev_id < rev_id',
                                        'p.fr_timestamp < rev_timestamp' ) ),
                                'n'     => array( 'INNER JOIN', array( // next review INNER
                                        'n.fr_page_id = rev_page',
                                        'n.fr_rev_id >= rev_id',
                                        'n.fr_timestamp >= rev_timestamp' ) )
                        )
                );

Vpovilaitis07:03, 8 February 2012
 
 
 
 
 

Draw the stable Image on stable pages

Hello,

i want to draw the stable Image: the green snag, on the stable sites, which have no unviewed versions. Is this possible?

141.35.213.22111:37, 25 January 2012

After approved not show images and return broken link to file. Only to unregistered user.

How example:

Before:

http://wiki-moscow.ru/Test111

After:

http://wiki-moscow.ru/Test112


Version:

http://wiki-moscow.ru/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:Version

or http://wiki-moscow.ru/Special:Version


P.S. I tried to use different versions of the "flaged revision" and received the same thing. MediaWiki 1.18

P.S.2. Not showed images only to unregistered user!

Serdtsev20:09, 11 December 2011

Hmmm.

After approved Not show images from Wikimedia Commons only. Registered users can see them. But unregistered users can see any images which was saved to the my wiki.

Serdtsev11:08, 13 December 2011

ForeignAPIRepos don't work with FR. It's probably possible to patch FR and FileRepo to handle this better (like always show current versions for foreign API repos).

Aaron03:08, 26 December 2011

Hi Araaon. Thank you for response.

May be possible now any way local modify the FR code that approved only text without any images?

Serdtsev06:53, 13 January 2012

Actually I'd just recommend filing a bug report to MediaWiki to let foreign files be fetched by sha1.

Aaron07:49, 13 January 2012

may be somehow temporarily disable approving images in the code? I will write in bagzila later, after a set up the MediaWiki engine for testing on my other free domain.

Serdtsev09:36, 13 January 2012
 
 
 
 
 

Mass Sight

Hello! Is there a way at all to sight all templates at once, either via the website or via some SQL script? I imported a large number of templates and I also had some I had on my wiki before and they're all unreviewed. Is there an easy way to review them all and still use FlaggedRevs on templates with changes after that? (<-- I don't want to disable it in the template namespace)

Joe Gazz8401:32, 8 January 2012

FlaggedRevs has a ReviewAllPages maintenance script. You change the line "'page_namespace' => FlaggedRevs::getReviewNamespaces()," to "'page_namespace' => NS_TEMPLATE," and run it.

Aaron02:21, 10 January 2012
 

Error for /maintenance/updateStats.php - "Notice: Undefined variable: times" + Misc

Hi Aaron, thanks to you and everyone else who worked on this!

1. I have MW 1.18 with the latest version of Flagged revisions. The file to run for the cronjob, updateStats.php is giving an error. Here's what I ran on the Shell access command prompt, with the output:

php /home/USER/public_html/wiki/extensions/FlaggedRevs/maintenance/updateStats.php
ValidationStatistics           Notice: Undefined variable: times in /home/USER/public_html/wiki/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php on line 359
completed in 0.06s

I had some other suggestions or questions:

2. To approve all current pages, I ran "reviewAllPages.php" for the two editors with the highest number of edits and that seemed to empty the "Unreviewed pages" list. Is that the right way to do this?

3. $wgFlaggedRevsLowProfile changes things for visitors. Could there be a variable that can make the visitor or anonymous IP (who is not a reviewer or editor) see nothing different at all from the stable page? That is, if that variable was set as true, they would not see the "eye" icon, or the "pending changes" tab for a page which has not been reviewed and approved yet.

4. When an IP tries to edit, it sees the warning text ('revreview-editnotice' in the i18n file) above the edit box when it tries to edit: "Your changes will be displayed to readers once an authorized user reviews them. (help)". However I noticed that a registered user who is not an editor or reviewer does not see this text. They are shown that notice only after they've made the edit. Is it possible to turn it on for them as well? That way, the pre-edit notice will be shown to everyone whose changes will need to be reviewed.

5. When an IP or a user who is not an editor or reviewer creates a page, that page shows a small "unchecked" box on the right of the page when it is viewed by visitors. Is it possible to have options for:

  • Dont show an unreviewed page to visitors and only show them a warning like "this new page is not visible because it has not been reviewed by an authorized user". Is that the solution? -> Extension:FlaggedRevs/Restricting unapproved revisions. I'm afraid that these changes would effect speed or do something else. I hope a build-in option ($wgShowStableVersionOnly) can made where if there's no stable version of a page, the contents are not showed to visitors, and only editors and reviewers would see it. This method can then be applied equally for new and existing pages.

6. For the situation in #5, $wgFlaggedRevsLowProfile should also work for new pages that have not been reviewed yet, like the way it works for unreviewed edits to existing pages. This way visitors will either see small notices (eye icon, "unchecked" box) or a more visible message with a blue background with the complete text "this new page has not been reviewed yet by an authorized user"

I have some coding experience in extensions and can help if needed to do some of the above. thanks.

Choshi01:00, 29 December 2011

PHP warning fixed in r108165.

Aaron19:04, 5 January 2012
 

2. That works. 3. That doesn't seem like a good GUI design, what about pages with pending changes? 4. I'll look into this...it was probably done to reduce clutter or something. 5. You'll have to use the code on that mw.org subpage if you want this kind of functionality I'm afraid. 6. Similiar to (3), though more reasonable. I'll look into that too.

Aaron06:50, 6 January 2012
 

Revisions remains the same even if included templates are changed

Edited by 0 users.
Last edit: 12:06, 13 September 2011

We are building a CMS around mediawki and we need to have signed logs of page readings, with the ability to freeze a page we can record the revisions number and it will "contain" the revision number of transcluded page

But I cannot find all the information I need

In order to make this "freeze" work there must be a add-on to the database, otherwise how can a page "know" which version of template to call? There might be another way, storing in the database the expanded text and forget about links So I wonder how does it work?

levreauj12:06, 13 September 2011

Here is how I think it is working

There is a table (called "flaggedtemplates") that links a particular flagged edit page with all of it's templates, it links not only with the templates names but the template revision ID. With the "freeze" option of FlaggedRevs nothing will channge in the calling page until the template revision is approved and even then for the update to appear on the calling page it has to be re-approuved. At this re-approval of the calling page the flaggedtemplates table is updated, the version of the calling page remains the same but the field for the template revision ID is updated. I don't know where the comment for the re-approval goes...

Levreauj20:23, 12 October 2011
 

Dont know if I understood your question but is that you're asking? "I'm changing the template but anonymous users do not see the recent changes to that template". If so, add the template namespace to Localsettings, e.g: - $wgFlaggedRevsNamespaces = array( NS_MAIN, NS_FILE, NS_TEMPLATE, NS_PROJECT, NS_CATEGORY, NS_HELP ); And then re-update all the reviews by running /flaggedrevs/maintenance/reviewAllPages.php 4 Where 4 is the user ID of a reviwer (your own, e.g.). Hope it works. I had this situation and this fix worked.

Choshi01:24, 3 January 2012
 

How to use Special:PendingChanges

So on Special:PendingChanges, what do the tags 'checked' and 'quality' next to revisions mean? Are those some sort of review levels? So a revision starts in quality and moves to checked and then stable? --Cneubauer 16:28, 21 April 2011 (UTC)

Cneubauer16:28, 21 April 2011

The latest "checked" is the stable version. A "quality" version is just a better "checked" version. You can get pending changes against the "stable" version, but you can also get pending changes against the "quality" version. Often the latest "checked" is up to date but the latest "quality" one is behind.

Aaron00:56, 10 December 2011
 

Help with skin

Hello!

By default, the extension use a "small icons and minimal text to show approval status of pages". However, it seems a little bugged with the Vector skin. However, choosing in "preferences" "Use detailed boxes to show approval status of pages", it is not. So, how can I turn as default, the non-bugged option?

Thanks!

201.15.204.7900:00, 25 May 2011

Use $wgSimpleFlaggedRevsUI.

Aaron00:55, 10 December 2011
 

chmod o+w extensions/FlaggedRevs/client

I'm pretty sure it's almost always a bad idea to make content served/executed by a webserver world-writable, even when there aren't untrusted local users on the machine...

Mdeegan03:49, 5 July 2011

Not sure who added that bit but someone fixed it it seems.

Aaron00:54, 10 December 2011
 

Merging pending contributions?

What happens in a scenario where User A makes a contribution and User B makes a contribution as well as some typo fixes but both users have contributed different data that are both quality submissions that should be accepted? are you forced to only pick one and the other user has to re-apply their changes to the now current/good revision?

Tekmosis14:34, 31 August 2011

They all build on top of each other. So you can accept them all by accepting the lasting one. You can also "accept" each if you want. You are not really accepting diffs but rather whole revisions technically. It just happens to be convenience to review diffs against a known good state.

Aaron00:52, 10 December 2011
 

Prevent picture page to show also unapproved versions

The extension seems to work for pages and included images, however when I click on the image I look at the list of all the versions I can also see and access the newer versions. Is there any way to prevent this? The point is that in the company's intranet, the unapproved versions of uploads should not be accessible. Thanks for answers!

Tschuliaen09:14, 2 September 2011

Comment in history

how can I get a comment in the history? Look here: w:de:Datei:Kommentar-Sichtung.png

ianusius ✆ Disk.20:04, 8 October 2011

That looks like UI clutter to me.

Aaron00:44, 10 December 2011
 

New pages marked as unreviewed by default?

Is it possible to tweak a setting somewhere to that new pages are not auto-reviwed? At the moment, when any of our users (non-reviewing rights) create a new page, it is marked as a stable version. As an admin I can un-approve the page, but I want to avoid having to do this. Can anyone help?

Jemima10:42, 9 December 2011

What versions of the extensions are you using and what user rights config do you have? The users must be getting 'autoreview' rights from some group they belong to.

Aaron00:42, 10 December 2011
 

Basic Settings Misleading

The section 'Basic Settings' states:

$wgFlaggedRevsNamespaces – Sets what namespaces to allow for reviewing. This is an array of integers. Look at the beginning of includes/defines.php to see what integer the default namespaces map to.

However, I after spending quite a while trying to get integers for namespaces to work, I found out the names of the namespaces had to be used. In fact, looking into FlaggedRevs.php, this is what is shown:

# Allowed namespaces of reviewable pages
$wgFlaggedRevsNamespaces = array( NS_MAIN, NS_FILE, NS_TEMPLATE );

The text on the Extension page should be updated!

Acaldwell15:53, 1 December 2011

NS_MAIN is a PHP constant which equals an integer. So the values *are* integers. Using constants just makes it more readable. You could technically do wgFlaggedRevsNamespaces = ( 0, 6, 10 );

Aaron00:38, 3 December 2011
 

Enable editor for comments

I want enable that editor can make a comment about his sighting. Unfortunately I get with the parameter $wgFlaggedRevsComments only that the reviewers can enter comments.

Where can I adjust that the editor has the option for comments?

80.243.35.19514:35, 28 November 2011

I would avoid that feature altogether ("review notes"). It was removed in later versions of the extension. However, in the latest version of the extension, everyone can leave a log comment when they review.

Aaron20:41, 30 November 2011
 

Banner in the print version

Is there a way the banner of FlaggedRevs also included in the print version ? Or you can add such an option?

Wniva11:35, 25 November 2011

It is not currently possible. I don't plan on adding it (If I were I would just make it hidden via CSS by default but leave the HTML). Aaron 21:16, 25 November 2011 (UTC)

Aaron21:16, 25 November 2011

I've tried to find a way in CSS to display the banner in printable version, but I'm not found it. Can someone give me a hint where I can adjust to these things?

Wniva14:38, 28 November 2011

You would need to change the source code. There are *->isPrintable() checks it the code that determine whether anything is added or not.

Aaron20:38, 30 November 2011
 
 
 

Get a list of random reviewed pages with the API ?

Hi everyone !

How come is it not possible to give a parameter 'random' to the API with the list reviewedpages (or any of the flaggedrevs list btw) ? I can't figure how to get a list of random reviewed pages in only one query to the API, it's so frustrating ! Can this feature be considered ?

Thx in advance !

81.255.33.22716:14, 10 November 2011

FlaggedRevs + Semantic MediaWiki issue

We are trying to build a QMS (Quality Management System) using MediaWiki. With FlaggedRevs we build the workflow of document states (In process, Prepared, Revised and Approved). With Semantic MediaWiki's special Search Data page we have an automatic updated index (this is our "All Documents" page).

When we change a page's state, the page disappears from "All Documents". When the page is edited, even if not modified, the page appears again. This is a problem because the people that revise (and approve) the documents should change the state and then edit the document (without change it) to make it available in "All Documents".

With a trace in the database, we determine that the problem is in the "semantic metadata" in the mw_smw_* tables.

Specifically, the problem is the following code during the review (or approval):

680 Query DELETE /* SMW::deleteSemanticData Sgc03 */ FROM `mw_smw_rels2` WHERE s_id = '53' 680 Query DELETE /* SMW::deleteSemanticData Sgc03 */ FROM `mw_smw_atts2` WHERE s_id = '53' 680 Query DELETE /* SMW::deleteSemanticData Sgc03 */ FROM `mw_smw_text2` WHERE s_id = '53' 680 Query DELETE /* SMW::deleteSemanticData Sgc03 */ FROM `mw_smw_spec2` WHERE s_id = '53' 680 Query DELETE /* SMW::deleteSemanticData Sgc03 */ FROM `mw_smw_subs2` WHERE s_id = '53' 680 Query DELETE /* SMW::deleteSemanticData Sgc03 */ FROM `mw_smw_subp2` WHERE s_id = '53' 680 Query DELETE /* SMW::deleteSemanticData Sgc03 */ FROM `mw_smw_inst2` WHERE s_id = '53' 680 Query DELETE /* SMW::deleteSemanticData Sgc03 */ FROM `mw_smw_redi2` WHERE s_title = 'Gestión_de_la_documentación' AND s_namespace = '0' 680 Query SELECT /* SMW::deleteSemanticData Sgc03 */ smw_id FROM `mw_smw_ids` WHERE smw_title = AND smw_namespace = '53' AND smw_iw = ':smw' 680 Query UPDATE /* SMW::deleteSemanticData Sgc03 */ `mw_smw_ids` SET smw_namespace = '0' WHERE smw_title = AND smw_namespace = '53' AND smw_iw = ':smw'

This code is in ./extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php

We try to comment this code in the case of a review (or approval), the semantic metadata is not deleted, and the page dont disappear from "All Documents" (OK). But then, when the page is legitimately re-edited, the semantic metadata is inserted again, and this result in a hang in subsequent edits.

We are looking for a way in which the state changes do not eliminate the document for "All Documents" that also intelligently handle subsequent edits

Any advice is wellcome

Regards, Alfonso

201.217.152.8213:20, 17 October 2011

How to make stable version by default ?

Hi, I've installed FlaggedRevs trying to build a Quality Management System. I need that users see the stable version by default, and write the following line in my LocalSettings.php:

$wgFlaggedRevsOverride = true;

However, the page ...: http://myserver/mediawiki/index.php?title=mypage Is the same as ......: http://myserver/mediawiki/index.php?title=mypage&stable=0

I need the stable=1 by default, how can I achieve this ?

Thanks in advance Alfonso

201.217.152.8222:01, 9 August 2011

actually it should be enough to simply set

 $wgDefaultUserOptions['flaggedrevsstable'] = false; 

to true; found in \extensions\FlaggedRevs\FlaggedRevs.php

The bad thing about this solution is, that the users could change this behaviour in their preferences.

84.253.4.9011:57, 22 August 2011
 

Disabling automatic sight

Can I somewhere disable the automatic sight? I don't found the variable or the function.

141.35.213.22109:22, 15 August 2011
Personal tools
Namespaces
Variants
Actions
Site
Support
Download
Development
Communication
Print/export
Toolbox