Extension:TimedMediaHandler/ReviewQueue

From MediaWiki.org
Jump to: navigation, search

Plan for subdividing the code to review in TimedMediaHandler and dependencies.

MwEmbedSupport:

  • This has existed for a long time; what reviews are needed? Presumably anything new...

TimedMediaHandler

  • Ian & Neil pair-reviewing the main files, may divide the smaller ones
  • We had a walkthrough from Michael Dale on Sept 27th
  • Code review notes ongoing here: TMHReview Etherpad
  • Should be external dependencies? Will not review
   88  ./handlers/WebMHandler/getid3/getid3.lib.php
   112 ./handlers/WebMHandler/getid3/getid3.php
   240 ./handlers/WebMHandler/getid3/module.audio-video.matroska.php
   40  ./handlers/WebMHandler/getid3/module.audio.flac.php
   56  ./handlers/WebMHandler/getid3/module.audio.ogg.php
   16  ./handlers/OggHandler/PEAR/File_Ogg/File/Ogg/Bitstream.php
   16  ./handlers/OggHandler/PEAR/File_Ogg/File/Ogg/Flac.php
   24  ./handlers/OggHandler/PEAR/File_Ogg/File/Ogg/Media.php
   16  ./handlers/OggHandler/PEAR/File_Ogg/File/Ogg/Speex.php
   24  ./handlers/OggHandler/PEAR/File_Ogg/File/Ogg/Theora.php
   48  ./handlers/OggHandler/PEAR/File_Ogg/File/Ogg/Vorbis.php
   48  ./handlers/OggHandler/PEAR/File_Ogg/File/Ogg.php
  • Code review comments and notes have been added here
   16  ./ApiQueryVideoInfo.php
   16  ./ApiTranscodeReset.php
   8   ./ApiTranscodeStatus.php
   16  ./handlers/OggHandler/OggHandler.php
   16  ./handlers/TextHandler/TextHandler.php
   8   ./handlers/WebMHandler/WebMHandler.php
   8   ./maintenance/WebVideoJobRunner.php
   8   ./mwEmbedLoader.php
   16  ./MwEmbedModules/EmbedPlayer/EmbedPlayer.config.php
   352 ./MwEmbedModules/EmbedPlayer/EmbedPlayer.i18n.php
   8   ./MwEmbedModules/EmbedPlayer/EmbedPlayer.loader.js
   8   ./MwEmbedModules/EmbedPlayer/EmbedPlayer.php
   raindrift assigned 2011-11-23 16  ./MwEmbedModules/EmbedPlayer/resources/iframeApi/mw.IFramePlayerApiClient.js
   raindrift assigned 2011-11-23 16  ./MwEmbedModules/EmbedPlayer/resources/iframeApi/mw.IFramePlayerApiServer.js
   112 ./MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
   8   ./MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerGeneric.js
   16  ./MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js
   72  ./MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerKplayer.js
   40  ./MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js
   raindrift assigned 2011-11-21 24  ./MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerVlc.js
   raindrift assigned 2011-11-21 16  ./MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js
   raindrift assigned 2011-11-21 24  ./MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js
   raindrift assigned 2011-11-21 8   ./MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayer.js
   raindrift assigned 2011-11-21 16  ./MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayers.js
   raindrift assigned 2011-11-21 24  ./MwEmbedModules/EmbedPlayer/resources/mw.MediaSource.js>
   raindrift assigned 2011-11-23 24  ./MwEmbedModules/EmbedPlayer/resources/mw.processEmbedPlayers.js
   raindrift assigned 2011-11-23 24  ./MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js
   raindrift assigned 2011-11-23 8   ./MwEmbedModules/EmbedPlayer/resources/skins/mvpcf/mw.PlayerSkinMvpcf.js
   neilk assigned 2011-11-23 112 ./MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
   neilk assigned 2011-11-21 104 ./MwEmbedModules/TimedText/resources/mw.TimedText.js
   neilk assigned 2011-11-21 24  ./MwEmbedModules/TimedText/resources/mw.TimedTextEdit.js
   neilk assigned 2011-11-21 8   ./MwEmbedModules/TimedText/TimedText.config.php
   208 ./MwEmbedModules/TimedText/TimedText.i18n.php
   8   ./MwEmbedModules/TimedText/TimedText.loader.js
   8   ./MwEmbedModules/TimedText/TimedText.php
   8   ./resources/ext.tmh.transcodetable.js
   8   ./resources/mw.MediaWikiPlayer.loader.js
   16  ./resources/mw.MediaWikiPlayerSupport.js
   8   ./resources/mw.PopUpThumbVideo.js
   8   ./tests/phpunit/ApiTestCaseVideoUpload.php
   8   ./tests/phpunit/TestApiUploadVideo.php
   8   ./tests/phpunit/TestTimeParsing.php
   8   ./tests/phpunit/TestVideoThumbnail.php
   8   ./tests/phpunit/TestVideoTranscode.php
   8   ./tests/selenium/EmbedPlayerLoadsTestCase.php
   8   ./tests/selenium/EmbedPlayerTestSuite.php
   24  ./TimedMediaHandler.hooks.php
   8   ./TimedMediaHandler.i18n.magic.php
   328 ./TimedMediaHandler.i18n.php
   16  ./TimedMediaHandler.php
   16  ./TimedMediaHandler_body.php
   8   ./TimedMediaIframeOutput.php
   8   ./TimedMediaThumbnail.php
   24  ./TimedMediaTransformOutput.php
   8   ./TimedTextPage.php
   16  ./TranscodeStatusTable.php
   48  ./WebVideoTranscode/WebVideoTranscode.php
   48  ./WebVideoTranscode/WebVideoTranscodeJob.php